This PR modernizes few analyzer implementations to follow better practices and be more solid. There is much more to cleanup, but it's a good step so far.

Youssef1313 added13 commits

August 30, 2025 10:56

Cleanup AbstractPropertiesCannotBeSerializedAnalyzer

48f773c

More cleanup

70d78c1

Cleanup AlwaysInterleaveDiagnosticAnalyzer

ee09985

Cleanup AtMostOneOrleansConstructorAnalyzer

81af29c

Cleanup GenerateAliasAttributesAnalyzer

30e4ec8

Cleanup no longer used helper

ccfa582

Cleanup GenerateGenerateSerializerAttributeAnalyzer

3de5dd9

Cleanup GrainInterfaceMethodReturnTypeDiagnosticAnalyzer

7ee5f07

Cleanup dead code

6ef7f7d

Cleanup IncorrectAttributeUseAnalyzer

fac8678

Cleanup SyntaxHelpers

a7f7f7d

Cleanup IdClashAttributeAnalyzer

7bca500

Cleanup NoRefParamsDiagnosticAnalyzer

a2dca5d

ReubenBond requested a review fromCopilot

October 1, 2025 17:55

CopilotAI reviewed

Oct 1, 2025

View reviewed changes

Copy link

Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR modernizes Orleans analyzer implementations by migrating from syntax-based analysis to semantic-based analysis using symbols. This improves reliability and follows analyzer best practices by avoiding error-prone syntax parsing.

Key changes:

Migration fromSyntaxNodeAnalysisContext toSymbolAnalysisContext across multiple analyzers
Introduction of newSymbolHelpers utility class for semantic operations
Removal of unused syntax-based helper methods fromSyntaxHelpers

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`test/Analyzers.Tests/AbstractPropertiesCannotBeSerializedAnalyzerTest.cs`	Removed UTF-8 BOM character
`src/Orleans.Analyzers/SyntaxHelpers.cs`	Removed unused syntax-based helper methods and made remaining methods private
`src/Orleans.Analyzers/SymbolHelpers.cs`	New utility class with semantic-based helper methods
`src/Orleans.Analyzers/SerializationAttributesHelper.cs`	Updated to use symbol-based analysis and removed unused properties
`src/Orleans.Analyzers/NoRefParamsDiagnosticAnalyzer.cs`	Migrated from syntax to symbol analysis
`src/Orleans.Analyzers/IncorrectAttributeUseAnalyzer.cs`	Migrated from syntax to symbol analysis
`src/Orleans.Analyzers/IdClashAttributeAnalyzer.cs`	Migrated from syntax to symbol analysis with improved type safety
`src/Orleans.Analyzers/GrainInterfaceMethodReturnTypeDiagnosticAnalyzer.cs`	Migrated from syntax to symbol analysis and simplified type checking
`src/Orleans.Analyzers/GenerateGenerateSerializerAttributeAnalyzer.cs`	Migrated from syntax to symbol analysis
`src/Orleans.Analyzers/GenerateAliasAttributesAnalyzer.cs`	Migrated from syntax to symbol analysis
`src/Orleans.Analyzers/AtMostOneOrleansConstructorAnalyzer.cs`	Migrated from syntax to symbol analysis with improved constructor counting
`src/Orleans.Analyzers/AlwaysInterleaveDiagnosticAnalyzer.cs`	Migrated from syntax to symbol analysis
`src/Orleans.Analyzers/AliasClashAttributeAnalyzer.cs`	Migrated from syntax to symbol analysis
`src/Orleans.Analyzers/AbstractPropertiesCannotBeSerializedAnalyzer.cs`	Migrated to operation-based analysis