- Notifications
You must be signed in to change notification settings - Fork830
remove DiaSymReader package dependencies since they're not used#4735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
mmitche commentedApr 18, 2018
@brettfo Does this mean that I should remove the dependency edges in the prodcon build graph? Who in the product now references these? |
MemberAuthor
brettfo commentedApr 18, 2018
Yes, you can remove the dependency edges. I don't know who else might reference these, but our references are now completely gone. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was recently discovered that we're not actually using the
Microsoft.DiaSymReaderandMicrosoft.DiaSymReader.PortablePdbpackages. I've verified bothbuildfromsource.cmdandbuildfromsource.shlocally, so this is to test CI. Next step will be to test a full build.