- Notifications
You must be signed in to change notification settings - Fork833
Add regression tests for FSharpPlus consumer scenarios affected by F# 9#19008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge2 commits intomainChoose a base branch fromcopilot/add-regression-tests-fsharp-plus
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+131 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
CopilotAI changed the title[WIP] Add regression tests for FSharpPlus consumer scenariosAdd regression tests for FSharpPlus consumer scenarios affected by F# 9Oct 16, 2025
Copilot finished work on behalf ofT-GroOctober 16, 2025 09:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR adds regression tests documenting two consumer-side failures reported inFSharpPlus issue #613 that occur with F# 9.
Overview
The tests reproduce real-world FSharpPlus patterns that currently fail to compile in F# 9, serving as regression tests to track when these issues are resolved in the compiler.
Test Scenarios
1. monad.plus SRTP Pattern (Currently Failing)
Tests the use of statically resolved type parameters (SRTP) for ad-hoc polymorphism with overloaded static members:
Current Error:
Type constraint mismatch when applying the default type 'obj' for a type inference variable. None of the types 'obj, int option' support the operator 'MPlus'2. Custom ResultTBuilder (Currently Passing)
Tests defining a custom computation expression builder for Result types:
This scenario currently works correctly in F# 9.
Test Configuration
Each test runs with three compiler configurations:
--langversion:8.0- F# 8 baseline--langversion:preview- F# 9 preview--langversion:preview --checknulls+- F# 9 preview with nullable reference typesImplementation Details
tests/FSharp.Compiler.ComponentTests/Language/FSharpPlusRegressionTests.fsTest Results
The failing monad.plus tests will serve as indicators when the SRTP resolution issue is fixed in the F# compiler.
Running the Tests
Related Issues
Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Clickhere to start the survey.