- Notifications
You must be signed in to change notification settings - Fork825
Sync from Azure DevOps: release/dev17.12#18741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
T-Gro wants to merge14 commits intorelease/dev17.12Choose a base branch
base:release/dev17.12
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Update nuget handling in fsirelease/dev17.12----#### AI description (iteration 1)#### PR ClassificationNew feature and enhancement.#### PR SummaryThis pull request updates the handling of NuGet packages in F# Interactive (FSI) and introduces new event handling for text views.- `Common/Extensions.fs`: Added `TextViewEventsHandler` and methods to handle text view events and caret positions.- `LanguageService/FSharpProjectOptionsManager.fs`: Enhanced project options management with new event subscriptions and caret position handling.- `Driver/ScriptClosure.fs`: Updated script closure processing to consider caret positions and package manager lines.- `FSharp.DependencyManager.Nuget/FSharp.DependencyManager.fs`: Added support for `usepackagetargets` option in NuGet package references.- `FSharp.Compiler.Private.Scripting.UnitTests/FSharpScriptTests.fs`: Added tests for the new `usepackagetargets` option in script evaluation.<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
de-loc----#### AI description (iteration 1)#### PR ClassificationCode cleanup#### PR SummaryThis pull request cleans up error handling and localization files by removing redundant translations and updating error messages.- `FSharp.DependencyManager.fs`: Replaced specific boolean error message with a more generic `ArgumentOutOfRangeException` message.- `FSDependencyManager.txt`: Removed the `invalidBooleanValue` error message.- `FSharpScriptTests.fs`: Updated test cases to reflect the new error message format.- Multiple localization files (`.xlf`): Removed the `invalidBooleanValue` translation entries.<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
normalize format
…es. -release/dev17.12
#### AI description (iteration 1)#### PR ClassificationNuGet patch update and build configuration adjustments.#### PR SummaryThis pull request updates the NuGet package versions and adjusts build configurations to support internal source builds and dependencies. It ensures compatibility with the latest Microsoft Build version and adds new package sources.- `eng/build.sh`: Added no-operation implementations for runtime arguments used in internal builds.- `eng/SourceBuildPrebuiltBaseline.xml`: Added new usage entries for several Microsoft Build components and System.Formats.Asn1.- `azure-pipelines.yml`: Enabled internal sources for source builds.- `eng/Versions.props`: Updated `MicrosoftBuildVersion` to 17.12.36.- `NuGet.config`: Added a new package source for `msbuild-Trusted`.<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
Contributor
github-actionsbot commentedJul 9, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
T-Gro commentedJul 9, 2025
Uh oh!
There was an error while loading.Please reload this page.
abonie approved these changesJul 9, 2025
/azp run |
| Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
NO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR syncs commits from the internal Azure DevOps mirror for branch 'release/dev17.12'. Please review and merge.