Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Sync from Azure DevOps: release/dev17.13#18740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
T-Gro wants to merge23 commits intorelease/dev17.13
base:release/dev17.13
Choose a base branch
Loading
fromsync/release-dev17.13-20250709121058

Conversation

T-Gro
Copy link
Member

This PR syncs commits from the internal Azure DevOps mirror for branch 'release/dev17.13'. Please review and merge.

KevinRansomand others added21 commitsMarch 25, 2025 20:15
Update nuget handling in fsi----#### AI description  (iteration 1)#### PR ClassificationNew feature#### PR SummaryThis pull request updates the handling of NuGet packages in FSI, adding new features and improving existing functionality.- `vsintegration/src/FSharp.Editor/Common/Extensions.fs`: Added `TextViewEventsHandler` and methods to handle text view events and caret position.- `vsintegration/src/FSharp.Editor/LanguageService/FSharpProjectOptionsManager.fs`: Enhanced project options management with event subscriptions for caret and focus changes.- `src/Compiler/Driver/ScriptClosure.fs`: Improved package manager handling with editor cursor awareness.- `src/FSharp.DependencyManager.Nuget/FSharp.DependencyManager.fs`: Added support for `usepackagetargets` option in NuGet package references.- `tests/FSharp.Compiler.Private.Scripting.UnitTests/FSharpScriptTests.fs`: Added tests for `usepackagetargets` option in script evaluation.<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
remove the need for loc strings----#### AI description  (iteration 1)#### PR ClassificationCode cleanup#### PR SummaryThis pull request cleans up localization files and refines error handling for boolean values.- Removed `invalidBooleanValue` translations from multiple `.xlf` files.- Updated error message for invalid boolean values in `FSharp.DependencyManager.fs`.- Adjusted unit tests in `FSharpScriptTests.fs` to reflect the new error message format.<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
…es. -release/dev17.13#### AI description  (iteration 1)#### PR ClassificationBug fix to prevent unnecessary package downloads.#### PR SummaryThis pull request addresses issue#18231 by fixing the logic that downloads unneeded packages in the NuGet dependency manager.- `FSharpProjectOptionsManager.fs`: Refactored to correctly handle text view and caret position retrieval.- `ScriptClosure.fs`: Simplified filtering of package manager lines.- `FSharp.DependencyManager.fs`: Streamlined error message handling for `usepackagetargets`.- `FSharpScriptTests.fs`: Adjusted test assertions to normalize error messages across different frameworks.- `Extensions.fs`: Fixed the parameter for `GetActiveView` to ensure correct view retrieval.<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
#### AI description  (iteration 1)#### PR ClassificationCompatibility update to ensure source build functionality with internal MSBuild version 17.13.#### PR SummaryThis pull request updates the build scripts and configuration files to maintain compatibility with internal MSBuild 17.13, ensuring smooth source build processes.- `eng/build.sh`: Added no-operation implementations for runtime arguments to support internal builds.- `eng/SourceBuildPrebuiltBaseline.xml`: Updated usage patterns to include new dependencies for MSBuild 17.13.- `azure-pipelines.yml`: Enabled internal source build parameters to facilitate source build processes.<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedJul 9, 2025
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-GroT-Gro added the NO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes labelJul 9, 2025
@T-Gro
Copy link
MemberAuthor

/run fantomas

github-actions[bot] reacted with thumbs up emoji

@github-actionsGitHub Actions
Copy link
Contributor

🔧 CLI Command Report

  • Command:/run fantomas
  • Outcome: success

✅ Patch applied:
- Files changed: 1
- Lines changed: 14

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@abonieabonieabonie approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
NO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes
Projects
Status: New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@T-Gro@abonie@KevinRansom@rainersigwald@actions-user

[8]ページ先頭

©2009-2025 Movatter.jp