Test cases added
Performance benchmarks added in case of performance changes
Release notes entry updated:
Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.
Release notes files:
- If anything undersrc/Compiler has been changed, please make sure to make an entry indocs/release-notes/.FSharp.Compiler.Service/<version>.md, where<version> is usually "highest" one, e.g.42.8.200
- If language feature was added (i.e.LanguageFeatures.fsi was changed), please add it todocs/release-notes/.Language/preview.md
- If a change toFSharp.Core was made, please make sure to editdocs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g.8.0.200.
Information about the release notes entries format can be found in thedocumentation.
Example:
- More inlines for Result module. (PR #16106)
- Correctly handle assembly imports with public key token of 0 length. (Issue #16359,PR #16363)
  *while! (Language suggestion #1038,PR #14238)
If you believe that release notes are not necessary for this PR, please addNO_RELEASE_NOTES label to the pull request.

trust in MEF

e2597f0

github-project-automationbot added this toF# Compiler and Tooling

Jun 2, 2025

github-project-automationbot moved this toNew inF# Compiler and Tooling

Jun 2, 2025

Copy link

Contributor

github-actionsbot commentedJun 2, 2025

❗ Release notes required

@majocha,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based onKeep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation athttps://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please addNO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes:open in github.dev

Change path	Release notes path	Description
`vsintegration/src`	docs/release-notes/.VisualStudio/18.0.md	No release notes found or release notes format is not correct

majocha commented

Jun 2, 2025

View reviewed changes

vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs

Comment on lines -54 to -57

		// We have a lock just in case if multi-threads try to create a new IFSharpWorkspaceService -
		// but we only want to have a single instance of the FSharpChecker regardless if there are multiple instances of IFSharpWorkspaceService.
		// In VS, we only ever have a single IFSharpWorkspaceService, but for testing we may have multiple; we still only want a
		// single FSharpChecker instance shared across them.

Copy link

ContributorAuthor

majochaJun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's see if this is still needed.

everything in background for starters

6f1154d

Copy link

ContributorAuthor

majocha commentedJun 2, 2025•
edited
Loading

Works ok in experimental instance. It seems we don't need the UI thread during package init.
This must wait because currently the vsix cannot be installed

Copy link

Member

T-Gro commentedJun 3, 2025

Thanks for taking this up@majocha .
This has the potential to speed up solution opening, so I am really glad the new API model allows us to make this split.

Lets merge this in after it can be locally tested.