Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Better error reporting foruse#17811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vzarytovskii merged 16 commits intodotnet:mainfromedgarfgp:better-error-reporing-for-ce-use
Oct 8, 2024
Merged

Better error reporting foruse#17811

vzarytovskii merged 16 commits intodotnet:mainfromedgarfgp:better-error-reporing-for-ce-use
Oct 8, 2024

Conversation

edgarfgp
Copy link
Contributor

@edgarfgpedgarfgp commentedSep 27, 2024•
edited
Loading

Description

Better error reporting foruse

Continuation of#17779

Before

Screenshot 2024-09-30 at 20 09 48

Screenshot 2024-09-30 at 20 10 12

After

letx11=     query{for cin[1..10]douse x={new System.IDisposablewith__.Dispose()=()}^^^yield1}letrun r2 r3=    result{use b= r2^^^return Ok0}

Checklist

  • Test cases added
  • Release notes entry updated

majocha reacted with hooray emoji
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedSep 27, 2024•
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/9.0.200.md

@edgarfgpedgarfgp marked this pull request as ready for reviewSeptember 30, 2024 19:27
@edgarfgpedgarfgp requested a review froma team as acode ownerSeptember 30, 2024 19:27
@edgarfgp
Copy link
ContributorAuthor

This is ready

@vzarytovskiivzarytovskiienabled auto-merge (squash)October 3, 2024 20:36
@edgarfgp
Copy link
ContributorAuthor

Can I have a second review please ?

auto-merge was automatically disabledOctober 4, 2024 16:55

Pull request was closed

@edgarfgpedgarfgp reopened thisOct 4, 2024
# Conflicts:#tests/FSharp.Compiler.ComponentTests/Language/ComputationExpressionTests.fs
@edgarfgp
Copy link
ContributorAuthor

Fixed merge conflicts and it is green again.

@vzarytovskiivzarytovskii merged commit69cc8a4 intodotnet:mainOct 8, 2024
32 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vzarytovskiivzarytovskiivzarytovskii approved these changes

@T-GroT-GroAwaiting requested review from T-Gro

@abonieabonieAwaiting requested review from abonie

Assignees
No one assigned
Labels
None yet
Projects
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@edgarfgp@vzarytovskii
[8]ページ先頭
©2009-2025 Movatter.jp