- Notifications
You must be signed in to change notification settings - Fork825
Fix14779#15384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix14779#15384
Uh oh!
There was an error while loading.Please reload this page.
Conversation
inosik commentedOct 11, 2023
Is this supposed to be released in VS 17.7? I'm still getting the issue I reported in#15258 with 17.7.5. |
vzarytovskii commentedOct 11, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Likely it didn't hit the bar, please check 17.8 preview and see if it works there. I am not sure we got approval for 17.7 for it Also, it might depend which SDK is used (in global.json) and which FSI (normal or coreclr) is used. |
This is what I see in 17.8:
|
inosik commentedOct 11, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thank you for the quick answer. I‘ll wait for 17.8 then. I just wondered, because the patch is in the release/dev17.7 branch and I thought this is the branch that 17.7.x is built off. I‘ll also check if the CoreCLR version changes anything, because I usually use the .NET Framework version. |
This image shows both scenarios operating correctly
Fixes:
#15258
#14779
#14779 was caused by: the parser needing an End of block following the indented submission. We use ';;'. The end of block allows the parser to reset indent expectations.
#15258 was caused by a lack of space between the # line-number statement in the submission vsfsi prepares for submission to fsi.
Image:
