NotificationsYou must be signed in to change notification settings
Fork825
Star4.1k

Commit40d789c

authored

VS enable diagnostics for unopened files (#15591)

* internalerror with MakeValueAssign fixed?* Add in optional setting for solution-wide background analysis* fix* telementry - lang service started will report background analysis flag

1 parentb4c26d8 commit40d789cCopy full SHA for 40d789c

File tree

18 files changed

+176

-17

lines changed

vsintegration/src
- FSharp.Editor
  - LanguageService
    - LanguageService.fs
  - Options
    - EditorOptions.fs
- FSharp.UIResources

18 files changed

+176

-17

lines changed

`‎vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs`

Lines changed: 16 additions & 17 deletions

Original file line number	Diff line number	Diff line change
`@@ -146,6 +146,9 @@ type internal FSharpWorkspaceServiceFactory [<Composition.ImportingConstructor>]`
`146`	`146`	`letcaptureIdentifiersWhenParsing=`
`147`	`147`	`editorOptions.LanguageServicePerformance.CaptureIdentifiersWhenParsing`
`148`	`148`
	`149`	`+// Default is false here`
	`150`	`+letsolutionCrawler= editorOptions.Advanced.SolutionBackgroundAnalysis`
	`151`	`+`
`149`	`152`	`use_eventDuration=`
`150`	`153`	`TelemetryReporter.ReportSingleEventWithDuration(`
`151`	`154`	`TelemetryEvents.LanguageServiceStarted,`
`@@ -163,6 +166,7 @@ type internal FSharpWorkspaceServiceFactory [<Composition.ImportingConstructor>]`
`163`	`166`	`nameof enableBackgroundItemKeyStoreAndSemanticClassification,`
`164`	`167`	`enableBackgroundItemKeyStoreAndSemanticClassification`
`165`	`168`	`nameof captureIdentifiersWhenParsing, captureIdentifiersWhenParsing`
	`169`	`+ nameof solutionCrawler, solutionCrawler`
`166`	`170`	`\|],`
`167`	`171`	`TelemetryThrottlingStrategy.NoThrottling`
`168`	`172`	`)`
`@@ -423,28 +427,23 @@ type internal FSharpLanguageService(package: FSharpPackage) =`
`423`	`427`	`override_.Initialize()=`
`424`	`428`	`base.Initialize()`
`425`	`429`
`426`		`-letglobalOptions=`
`427`		`- package`
`428`		`- .ComponentModel`
`429`		`- .DefaultExportProvider`
`430`		`- .GetExport<FSharpGlobalOptions>()`
`431`		`- .Value`
	`430`	`+letexportProvider= package.ComponentModel.DefaultExportProvider`
	`431`	`+letglobalOptions= exportProvider.GetExport<FSharpGlobalOptions>().Value`
`432`	`432`
`433`		`- globalOptions.BlockForCompletionItems<-false`
`434`		`- globalOptions.SetBackgroundAnalysisScope(openFilesOnly=true)`
	`433`	`+letworkspace= package.ComponentModel.GetService<VisualStudioWorkspace>()`
`435`	`434`
`436`		`-letglobalOptions=`
`437`		`-package`
`438`		`- .ComponentModel`
`439`		`- .DefaultExportProvider`
`440`		`- .GetExport<FSharpGlobalOptions>()`
`441`		`- .Value`
	`435`	`+letsolutionAnalysis=`
	`436`	`+workspace`
	`437`	`+ .Services`
	`438`	`+ .GetService<EditorOptions>()`
	`439`	`+ .Advanced`
	`440`	`+ .SolutionBackgroundAnalysis`
`442`	`441`
`443`		`- globalOptions.BlockForCompletionItems<-false`
	`442`	`+ globalOptions.SetBackgroundAnalysisScope(openFilesOnly=not solutionAnalysis)`
`444`	`443`
`445`		`-lettheme=`
`446`		`- package.ComponentModel.DefaultExportProvider.GetExport<ISetThemeColors>().Value`
	`444`	`+ globalOptions.BlockForCompletionItems<-false`
`447`	`445`
	`446`	`+lettheme= exportProvider.GetExport<ISetThemeColors>().Value`
`448`	`447`	`theme.SetColors()`
`449`	`448`
`450`	`449`	`override_.ContentTypeName= FSharpConstants.FSharpContentTypeName`

`‎vsintegration/src/FSharp.Editor/Options/EditorOptions.fs`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -114,6 +114,7 @@ type AdvancedOptions =`
`114`	`114`	`IsInlineReturnTypeHintsEnabled:bool`
`115`	`115`	`IsLiveBuffersEnabled:bool`
`116`	`116`	`SendAdditionalTelemetry:bool`
	`117`	`+ SolutionBackgroundAnalysis:bool`
`117`	`118`	`}`
`118`	`119`
`119`	`120`	`static memberDefault=`
`@@ -125,6 +126,7 @@ type AdvancedOptions =`
`125`	`126`	`IsInlineReturnTypeHintsEnabled=false`
`126`	`127`	`IsLiveBuffersEnabled= FSharpExperimentalFeaturesEnabledAutomatically`
`127`	`128`	`SendAdditionalTelemetry=true`
	`129`	`+ SolutionBackgroundAnalysis=false`
`128`	`130`	`}`
`129`	`131`
`130`	`132`	`[<CLIMutable>]`

`‎vsintegration/src/FSharp.UIResources/AdvancedOptionsControl.xaml`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,10 @@`
`42`	`42`	`<CheckBoxx:Name="toggleSendAdditionalTelemetry"IsChecked="{Binding SendAdditionalTelemetry}"`
`43`	`43`	`Content="{x:Static local:Strings.Send_Additional_Telemetry}"/>`
`44`	`44`	`</GroupBox>`
	`45`	`+ <GroupBoxHeader="{x:Static local:Strings.Background_analysis}">`
	`46`	`+ <CheckBoxx:Name="toggleSolutionBackgroundAnalysis"IsChecked="{Binding SolutionBackgroundAnalysis}"`
	`47`	`+Content="{x:Static local:Strings.Analyze_full_solution_on_background}"/>`
	`48`	`+ </GroupBox>`
`45`	`49`	`</StackPanel>`
`46`	`50`	`</ScrollViewer>`
`47`	`51`	`</Grid>`

`‎vsintegration/src/FSharp.UIResources/Strings.Designer.cs`

Lines changed: 18 additions & 0 deletions

Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.