Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update OpenTelemetryChatClient to 1.34#6466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
stephentoub merged 1 commit intodotnet:mainfromstephentoub:otel134
May 29, 2025

Conversation

@stephentoub
Copy link
Member

@stephentoubstephentoub commentedMay 20, 2025•
edited by dotnet-policy-servicebot
Loading

cc:@lmolkova

Microsoft Reviewers:Open in CodeFlow

@stephentoubstephentoub requested a review froma team as acode ownerMay 20, 2025 13:46
@stephentoubstephentoub requested a review fromCopilotMay 20, 2025 13:46
@github-actionsgithub-actionsbot added the area-aiMicrosoft.Extensions.AI libraries labelMay 20, 2025
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR updates the OpenTelemetry semantic conventions to v1.34 and adds conversation-level tagging to the chat client.

  • Introduce a newConversation.Id constant for Gen AI telemetry.
  • Bump documentation references from v1.33 to v1.34.
  • InstrumentOpenTelemetryChatClient to tagConversationId on streaming responses.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

FileDescription
src/Libraries/Microsoft.Extensions.AI/OpenTelemetryConsts.csAddedConversation.Id constant under Gen AI telemetry.
src/Libraries/Microsoft.Extensions.AI/Embeddings/OpenTelemetryEmbeddingGenerator.csUpdated semantic conventions version to v1.34 in remarks.
src/Libraries/Microsoft.Extensions.AI/ChatCompletion/OpenTelemetryChatClient.csUpdated spec version docs and added tagging ofConversationId on streaming responses.
Comments suppressed due to low confidence (2)

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/OpenTelemetryChatClient.cs:250

  • Consider adding or updating unit/integration tests to verify thatConversationId is correctly added as a tag on activities, ensuring your new telemetry behaviour is covered.
if (options.ConversationId is string conversationId)

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/OpenTelemetryChatClient.cs:246

  • For consistent telemetry, also apply theConversationId tag in the non-streamingGetResponseAsync override so both chat paths include conversation context.
public override async IAsyncEnumerable<ChatResponseUpdate> GetStreamingResponseA

@stephentoubstephentoubenabled auto-merge (squash)May 29, 2025 03:26
@stephentoubstephentoub merged commitc01d681 intodotnet:mainMay 29, 2025
7 checks passed
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 28, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

Copilot code reviewCopilotCopilot left review comments

@eiriktsarpaliseiriktsarpaliseiriktsarpalis approved these changes

Assignees

@stephentoubstephentoub

Labels

area-aiMicrosoft.Extensions.AI libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stephentoub@eiriktsarpalis
[8]ページ先頭
©2009-2025 Movatter.jp