- Notifications
You must be signed in to change notification settings - Fork845
Fix Process Metric calculation in CgroupsV2#6321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
evgenyfedorov2 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why do we need this change?
TheResourceUtilizationInstruments.ProcessCpuUtilization metric is deprecated (unofficially).ResourceUtilizationInstruments.ContainerCpuRequestUtilization is the replacement and it already has the right calculation logic
...raries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationProvider.cs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
...raries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationProvider.cs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/Log.cs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
e5b6b02 intodotnet:mainUh oh!
There was an error while loading.Please reload this page.
evgenyfedorov2 commentedApr 22, 2025
/backport to release/9.4 |
Started backporting torelease/9.4:https://github.com/dotnet/extensions/actions/runs/14599507495 |
@evgenyfedorov2 an error occurred while backporting to "release/9.4", please check the run log for details! Error:@evgenyfedorov2 is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public onhttps://github.com/orgs/dotnet/people?query=evgenyfedorov2 |
evgenyfedorov2 commentedApr 22, 2025
/backport to release/9.4 |
Started backporting torelease/9.4:https://github.com/dotnet/extensions/actions/runs/14599549296 |
Uh oh!
There was an error while loading.Please reload this page.
Missed updating the process metric in first check-in. Updating the same to use correct calculations behind the flag, and to ensure CpuUtilization() is not invoked at all.
Microsoft Reviewers:Open in CodeFlow