@RussKie@stephentoub Looks like thedotnet-extensions-ai team is being included as required on all eval library PRs despite the following lines in the CODEOWNERS files (wheredotnet-extensions-ai-evaluation appears ahead ofdotnet-extensions-ai).

Any ideas on how we can fix the reviewer tagging to only include thedotnet-extensions-ai-evaluation team?

https://github.com/dotnet/extensions/blob/main/.github/CODEOWNERS#L20C1-L22C116

@RussKie@stephentoub Looks like thedotnet-extensions-ai team is being included as required on all eval library PRs despite the following lines in the CODEOWNERS files (wheredotnet-extensions-ai-evaluation appears ahead ofdotnet-extensions-ai).

Any ideas on how we can fix the reviewer tagging to only include thedotnet-extensions-ai-evaluation team?

main/.github/CODEOWNERS#L20C1-L22C116

It's because of this:

It could be that the order is reversed. If reversing doesn't help, then you'll need to explicitly call out MEAI libraries.
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

@RussKie@stephentoub Looks like thedotnet-extensions-ai team is being included as required on all eval library PRs despite the following lines in the CODEOWNERS files (wheredotnet-extensions-ai-evaluation appears ahead ofdotnet-extensions-ai).
Any ideas on how we can fix the reviewer tagging to only include thedotnet-extensions-ai-evaluation team?
main/.github/CODEOWNERS#L20C1-L22C116

It's because of this:

extensions/.github/CODEOWNERS

Lines 24 to 27 in2f973c9

	/src/Libraries/Microsoft.Extensions.AI@dotnet/dotnet-extensions-ai
	/src/Libraries/Microsoft.Extensions.AI.*@dotnet/dotnet-extensions-ai
	/test/Libraries/Microsoft.Extensions.AI@dotnet/dotnet-extensions-ai
	/test/Libraries/Microsoft.Extensions.AI.*@dotnet/dotnet-extensions-ai

It could be that the order is reversed. If reversing doesn't help, then you'll need to explicitly call out MEAI libraries.https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

@RussKie Thanks - I have pushed a commit to this PR that reverses the order. Could you please approve if it looks good?

FYI@peterwald Looks like CI flaked out with the following error (same as#5901)

VSTest(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Tests failed: /mnt/vss/_work/1/s/artifacts/TestResults/Release/Microsoft.Extensions.Caching.Hybrid.Tests_net8.0_x64.html [net8.0|x64]

Looks like only the Ubuntu leg failed - Windows is past the point of failure - so perhaps the failure is intermittent / non-deterministic.

‼️Found issues‼️

🎉Good job! The coverage increased 🎉
UpdateMinCodeCoverage in the project files.

Full code coverage report:https://dev.azure.com/dnceng-public/public/_build/results?buildId=951837&view=codecoverage-tab

‼️Found issues‼️

🎉Good job! The coverage increased 🎉
UpdateMinCodeCoverage in the project files.

Full code coverage report:https://dev.azure.com/dnceng-public/public/_build/results?buildId=951897&view=codecoverage-tab