Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add service lifetime support to DI helpers.#5880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
eiriktsarpalis merged 3 commits intodotnet:mainfromeiriktsarpalis:meai-di-lifetimes
Feb 12, 2025

Conversation

@eiriktsarpalis
Copy link
Member

@eiriktsarpaliseiriktsarpalis commentedFeb 11, 2025•
edited by dotnet-policy-servicebot
Loading

Adds aServiceLifetime optional parameter to all the DI helpers, defaulting toSingleton.

Fix#5875.

Microsoft Reviewers:Open in CodeFlow

@dotnet-comment-bot
Copy link
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.AI.OpenAILine7768.75 🔻
Microsoft.Extensions.AI.OpenAIBranch7750.41 🔻
Microsoft.Extensions.AI.OllamaLine8078.2 🔻
Microsoft.Extensions.Caching.HybridLine8682.77 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉Good job! The coverage increased 🎉
UpdateMinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.AzureAIInference9192
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.Abstractions8385

Full code coverage report:https://dev.azure.com/dnceng-public/public/_build/results?buildId=948675&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.Caching.HybridLine8682.77 🔻
Microsoft.Extensions.AI.OllamaLine8078.2 🔻
Microsoft.Extensions.AI.OpenAILine7768.75 🔻
Microsoft.Extensions.AI.OpenAIBranch7750.41 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉Good job! The coverage increased 🎉
UpdateMinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.AzureAIInference9192
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.Abstractions8385

Full code coverage report:https://dev.azure.com/dnceng-public/public/_build/results?buildId=950106&view=codecoverage-tab

@eiriktsarpaliseiriktsarpalis merged commitb67faa0 intodotnet:mainFeb 12, 2025
6 checks passed
@eiriktsarpaliseiriktsarpalis deleted the meai-di-lifetimes branchFebruary 12, 2025 18:54
@jeffhandleyjeffhandley added the area-aiMicrosoft.Extensions.AI libraries labelMar 7, 2025
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes

@SteveSandersonMSSteveSandersonMSAwaiting requested review from SteveSandersonMS

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-aiMicrosoft.Extensions.AI libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MEAI] IChatClient dependency extensions should support lifetimes beyond singleton

4 participants

@eiriktsarpalis@dotnet-comment-bot@stephentoub@jeffhandley
[8]ページ先頭
©2009-2025 Movatter.jp