Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

AI Templates - Fixes for Ollama and OpenAI scenarios#5855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jmatthiesen merged 10 commits intomainfromjmatthiesen/templateFixes
Feb 10, 2025

Conversation

@jmatthiesen
Copy link
Contributor

@jmatthiesenjmatthiesen commentedFeb 7, 2025•
edited
Loading

Fixes several issues for the different combinations of environment choices:

  • Fixed Azure AI Search integration by adding a check in the data ingestor to see if there are documents to delete before trying to delete them.
  • Adjusted the main chat prompt so that citations work with Ollama/Llama3.2 after recent changes - verified it works for all other supported AI model providers
  • Fixed using statements when pairing OpenAI with Azure AI Search (was missing ausing Azure statement)
  • Removed the Attach Media button after a recent decision to not include that for now.
  • Fixed the conditionals in Chat.razor to include the proper code for Ollama.
Microsoft Reviewers:Open in CodeFlow

@dotnet-comment-bot
Copy link
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.AI.OllamaLine8078.25 🔻
Microsoft.Extensions.Caching.HybridLine8682.85 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉Good job! The coverage increased 🎉
UpdateMinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.OpenAI7778
Microsoft.Extensions.AI.Abstractions8384

Full code coverage report:https://dev.azure.com/dnceng-public/public/_build/results?buildId=943766&view=codecoverage-tab

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
@dotnet-comment-bot
Copy link
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.Caching.HybridLine8682.77 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻
Microsoft.Extensions.AI.OllamaLine8078.25 🔻

🎉Good job! The coverage increased 🎉
UpdateMinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.Abstractions8384
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.OpenAI7778

Full code coverage report:https://dev.azure.com/dnceng-public/public/_build/results?buildId=944406&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.AI.OllamaLine8078.11 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻
Microsoft.Extensions.Caching.HybridLine8682.77 🔻

🎉Good job! The coverage increased 🎉
UpdateMinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.AzureAIInference9192
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.Abstractions8385

Full code coverage report:https://dev.azure.com/dnceng-public/public/_build/results?buildId=944923&view=codecoverage-tab

@jmatthiesenjmatthiesen merged commit15f354c intomainFeb 10, 2025
6 checks passed
@jmatthiesenjmatthiesen deleted the jmatthiesen/templateFixes branchFebruary 10, 2025 21:00
@jeffhandleyjeffhandley added the area-ai-templatesMicrosoft.Extensions.AI.Templates labelMar 7, 2025
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@MackinnonBuckMackinnonBuckMackinnonBuck left review comments

@SteveSandersonMSSteveSandersonMSSteveSandersonMS approved these changes

Assignees

@jmatthiesenjmatthiesen

Labels

area-ai-templatesMicrosoft.Extensions.AI.Templates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jmatthiesen@dotnet-comment-bot@SteveSandersonMS@MackinnonBuck@jeffhandley
[8]ページ先頭
©2009-2025 Movatter.jp