Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use unsafe relaxed escaping inAIJsonUtilities.DefaultOptions.#5850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
eiriktsarpalis merged 2 commits intodotnet:mainfromeiriktsarpalis:relax-escaping
Feb 7, 2025

Conversation

@eiriktsarpalis
Copy link
Member

@eiriktsarpaliseiriktsarpalis commentedFeb 6, 2025•
edited by dotnet-policy-servicebot
Loading

It is common for AI vendor APIs to embed JSON documents inside JSON strings, which results in quotes and most non-ASCII content being escaped and confusing consuming LLMs. This updates the default STJ options to useJavaScriptEncoder.UnsafeRelaxedJsonEscaping.
 
FYI@GrabYourPitchforks@SergeyMenshykh

Microsoft Reviewers:Open in CodeFlow

@dotnet-comment-bot
Copy link
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.Caching.HybridLine8682.77 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻
Microsoft.Extensions.AI.OllamaLine8078.25 🔻

🎉Good job! The coverage increased 🎉
UpdateMinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.OpenAI7778
Microsoft.Extensions.AI.Abstractions8384
Microsoft.Extensions.AI8889

Full code coverage report:https://dev.azure.com/dnceng-public/public/_build/results?buildId=943071&view=codecoverage-tab

@eiriktsarpaliseiriktsarpalisenabled auto-merge (squash)February 6, 2025 20:07
@dotnet-comment-bot
Copy link
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.Caching.HybridLine8682.77 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻
Microsoft.Extensions.AI.OllamaLine8078.25 🔻

🎉Good job! The coverage increased 🎉
UpdateMinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.OpenAI7778
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.Abstractions8384

Full code coverage report:https://dev.azure.com/dnceng-public/public/_build/results?buildId=943191&view=codecoverage-tab

@eiriktsarpaliseiriktsarpalis merged commit11ccd68 intodotnet:mainFeb 7, 2025
6 checks passed
@eiriktsarpaliseiriktsarpalis deleted the relax-escaping branchFebruary 7, 2025 15:03
@jeffhandleyjeffhandley added the area-aiMicrosoft.Extensions.AI libraries labelMar 7, 2025
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-aiMicrosoft.Extensions.AI libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eiriktsarpalis@dotnet-comment-bot@stephentoub@jeffhandley
[8]ページ先頭
©2009-2025 Movatter.jp