Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove Tailwind and NPM dependency from chat template#5846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
MackinnonBuck merged 18 commits intomainfrommbuck/ai-template-remove-npm
Feb 5, 2025

Conversation

@MackinnonBuck
Copy link
Member

@MackinnonBuckMackinnonBuck commentedFeb 4, 2025•
edited
Loading

This PR:

  1. Removes tailwind classes from Razor components and replaces them with CSS classes defined in the project
  2. Removes NPM as a dependency and instead includes external dependencies directly in thewwwroot folder

Fixeshttps://github.com/dotnet/ai-private-planning/issues/272
Fixeshttps://github.com/dotnet/ai-private-planning/issues/273

Microsoft Reviewers:Open in CodeFlow

…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.css
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
@dotnet-comment-bot
Copy link
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻
Microsoft.Extensions.Caching.HybridLine8677.82 🔻
Microsoft.Extensions.AI.OllamaLine8078.25 🔻

🎉Good job! The coverage increased 🎉
UpdateMinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.OpenAI7778
Microsoft.Extensions.AI.Abstractions8384
Microsoft.Extensions.AI8889

Full code coverage report:https://dev.azure.com/dnceng-public/public/_build/results?buildId=940194&view=codecoverage-tab

Copy link
Member

@SteveSandersonMSSteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Excellent - thanks very much! What you've done with the CSS looks perfect.

I added some minor suggestions about using CSS shorthand syntax in a few places. I'm pretty sure none of them will change the resulting styles, but it's possible I could have a typo in there so please let me know if anything looks wrong.

MackinnonBuck reacted with heart emoji
MackinnonBuckand others added8 commitsFebruary 5, 2025 09:07
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatInput.razor.cssCo-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.cssCo-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.cssCo-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageList.razor.cssCo-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.cssCo-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.cssCo-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.cssCo-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.cssCo-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
MackinnonBuckand others added4 commitsFebruary 5, 2025 09:10
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.cssCo-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
@MackinnonBuckMackinnonBuckenabled auto-merge (squash)February 5, 2025 17:34
@dotnet-comment-bot
Copy link
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.AI.OllamaLine8078.25 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉Good job! The coverage increased 🎉
UpdateMinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.Abstractions8384
Microsoft.Extensions.Caching.Hybrid8687
Microsoft.Extensions.AI.OpenAI7778
Microsoft.Extensions.AI8889

Full code coverage report:https://dev.azure.com/dnceng-public/public/_build/results?buildId=941270&view=codecoverage-tab

@MackinnonBuckMackinnonBuck merged commit3640389 intomainFeb 5, 2025
6 checks passed
@MackinnonBuckMackinnonBuck deleted the mbuck/ai-template-remove-npm branchFebruary 5, 2025 18:13
@jeffhandleyjeffhandley added the area-ai-templatesMicrosoft.Extensions.AI.Templates labelMar 7, 2025
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@SteveSandersonMSSteveSandersonMSSteveSandersonMS approved these changes

@jmatthiesenjmatthiesenAwaiting requested review from jmatthiesen

Assignees

@MackinnonBuckMackinnonBuck

Labels

area-ai-templatesMicrosoft.Extensions.AI.Templates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MackinnonBuck@dotnet-comment-bot@SteveSandersonMS@jeffhandley
[8]ページ先頭
©2009-2025 Movatter.jp