- Notifications
You must be signed in to change notification settings - Fork845
Closed
Description
Description
Both official build and PR validation are setting -warnAsError 0
This allowed warnings to creep in. These are only caught in the source-index leg since it happens to call a different entry point that doesn't apply this setting.
Reproduction Steps
Buildeng/common/build.ps1 -restore -build -binarylog -ci
Expected behavior
build fails
Actual behavior
build succeeds since CI should protect against adding warnings
Regression?
Yes, regressed in5ca1721
Known Workarounds
No response
Configuration
No response
Other information
Bug is here:
Line 14 ina0e6496
| [boolean]$warnAsError=$false,# NOTE: inverted the Arcade's default |
Lines 131 to 134 ina0e6496
| # The Arcade's default is "warnAsError=true", we want the opposite by default. | |
| if [["$hasWarnAsError"==false ]];then | |
| properties="$properties --warnAsError false" | |
| fi |