- Notifications
You must be signed in to change notification settings - Fork3.3k
Fix FK dependency ordering when replacing owned entities with foreign key references#36769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge3 commits intorelease/10.0Choose a base branch fromcopilot/fix-36059
base:release/10.0
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+108 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
…refinementCo-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
CopilotAI changed the title[WIP] FK dependency ordering wrong when replacing an inline owned entityFix FK dependency ordering when replacing owned entities with foreign key referencesSep 12, 2025
Copilot finished work on behalf ofAndriySvyrydSeptember 12, 2025 23:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR addresses a critical issue where Entity Framework Core generates SQL commands in the wrong order when replacing an owned entity that has foreign key relationships to other entities, causing FK constraint violations.
Problem
When an owned entity (like
File) references another entity (likeContent) through a foreign key, and the owned entity is replaced duringSaveChanges(), EF Core was generating commands in this incorrect order:This causes a foreign key constraint violation because the
UPDATEcommand tries to referenceContent(Id=2)before it's inserted, and theDELETEcommand tries to removeContent(Id=1)while it's still being referenced.Solution
The fix modifies the
CanCreateDependencymethod inCommandBatchPreparerto properly handle foreign key dependencies for owned entities. Previously, the dependency tracking logic was excluding owned entity FK relationships under the assumption they were "handled elsewhere," but this was incorrect for owned entities that reference non-owned entities.The corrected command order is:
Changes Made
CanCreateDependencyto identify owned entities that have FK relationships to non-owned entitiesBatchCommands_sorts_FK_dependencies_correctly_when_replacing_owned_entityto verify the fixTest Case
The fix handles scenarios like:
Addressing#36059.
✨ Let Copilot coding agentset things up for you — coding agent works faster and does higher quality work when set up for your repo.