Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Merge branch 'release/9.0-staging' => 'release/9.0'#35601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AndriySvyryd merged 3 commits intorelease/9.0fromrelease/9.0-staging
Feb 10, 2025

Conversation

@AndriySvyryd
Copy link
Member

No description provided.

maumarand others added3 commitsJanuary 14, 2025 01:06
…Null for Joined EntitiesFixes#35393DescriptionIn EF9 we refactored some optimizations we performed on generated SQL - we are now applying them earlier (as part of SqlExpressionFactory. However, one of those optimizations is only correct for non-nullable arguments, and at the time we apply them we don't have full nullability information. Fix is to only apply this optimization when we know the argument is non-nullable.Customer impactData corruption. Queries comparing nullable boolean property to a constant (true/false) produced incorrect results (data corruption). Workaround is to rewrite the query to add missing null checks, but this is not intuitive at all.How foundCustomer report on 9.0.0RegressionYes, from 8.0.TestingAdded tests for the scenarios affected as well as test that brute-forces all combinations of comparisons between nullable arguments in variety of scenarios.RiskLow, we are just removing the optimization that was incorrect. After removal, the queries produced are the same as in EF8. Quirk added, just in case.
@AndriySvyrydAndriySvyryd merged commitf567bec intorelease/9.0Feb 10, 2025
8 checks passed
This was referencedJul 22, 2025
This was referencedNov 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@rojirojiroji approved these changes

@maumarmaumarAwaiting requested review from maumar

@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AndriySvyryd@roji@maumar

[8]ページ先頭

©2009-2025 Movatter.jp