Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[release/9.0] Fix TPC equality check inside subquery predicate (#35120)#35201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
roji merged 1 commit intodotnet:release/9.0-stagingfromroji:GetTable9
Nov 26, 2024

Conversation

@roji
Copy link
Member

@rojiroji commentedNov 25, 2024
edited
Loading

Fixes#35118
Port of#35120

Description
The deep query pipeline re-architecting in 9.0 included turning our SQL expression tree into a real tree rather than a graph, i.e. removing cycles where a SQL table was referenced both from its containing SelectExpression, and from any referencing columns. As a result, a changed predicate check for TPC inheritance was broken and did not correctly access the column's table when the column was nested in a subquery and referenced an outer table.

Customer impact
LINQ queries including a minimal equality predicate where a column references an outer table are now broken. For example:

varresults=awaitcontext.As.Where(a=>context.As.Where(g=>a.Name=="A").Any()).ToListAsync();

These queries are sufficiently common, and the fix sufficiently simple, that servicing seems justified.

How found
Customer reported on 9.0.0

Regression
Yes, from 8.0.

Testing
Test added.

Risk
Low, quirk added.

@rojiroji marked this pull request as ready for reviewNovember 25, 2024 15:50
@rojiroji requested a review froma teamNovember 25, 2024 16:17
@roji
Copy link
MemberAuthor

Approved via email

@rojiroji merged commita8c7b9d intodotnet:release/9.0-stagingNov 26, 2024
7 checks passed
@rojiroji deleted the GetTable9 branchNovember 26, 2024 19:41
This was referencedJul 22, 2025
This was referencedNov 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@ajcvickersajcvickersajcvickers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roji@ajcvickers

[8]ページ先頭

©2009-2025 Movatter.jp