- Notifications
You must be signed in to change notification settings - Fork3.3k
InMemoryTable: Make IsConcurrencyConflict() method more readable#33561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
y0ung3r commentedApr 18, 2024
@dotnet-policy-service agree |
cincuranet approved these changesApr 18, 2024
Contributor
cincuranet left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM@ajcvickers, but I'll leave final decision to you.
ajcvickers approved these changesApr 21, 2024
Contributor
ajcvickers commentedApr 21, 2024
Thanks for the contribution! |
roji pushed a commit to roji/efcore that referenced this pull requestApr 22, 2024
This was referencedJul 22, 2025
This was referencedNov 24, 2025
Open
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are not related to any issue.
Changed:
Checklist:
I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the teamCommit messages follow this format:New tests for the changes have been added (for bug fixes / features)