- Notifications
You must be signed in to change notification settings - Fork162
Oligopoly update#79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for another pull request. Feel free to try it if you want to, but I can update the web version of the code for you to match your latest console version. I'll review this pull request as soon as I can. |
Okay, at least I tried :D |
e8edd7a to1eea61cCompareI think I fixed it... feel dumb :D |
ZacharyPatten commentedJun 10, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Okay I had some time to review the pull request and here are some comments I have: I don't think there should be multiple screens for choosing game-mode/difficulty. Right now the code has both a "GAME MODE" screen and a "DIFFICULTY" screen. Instead just have a single options screen maybe with a check box for having "random starting stock values" as a toggle-able option. I like the idea of adding different difficulties, but changing the
|
If you would like me to make the changes to difficulty that I am recommending let me know. But since that would be a change to the game's design I wanted to wait and hear your thoughts before I made that change. |
Thanks for reviewing my code! Yes, I think that changing the chances of events would be more interesting than changing the win/lose conditions. I did not even think about such an implementation of difficulties, thanks for the improved idea! Also, as a suggestion, we can add another checkbox (along with the random mode) that will allow the player to manually adjust the amount of money at the start. It can be called something likecustom mode or something (and we also need to prevent the player from selecting both modes at the same time). What do you think? |
Yeah having a slider or whatever for initial funds is probably a good idea. :) Would you like me to jump in and implement these changes your would you like to work on them? I just don't want us to step on each other's toes by both working on those changes at the same time. |
To be honest, I need help with the implementation of this :D I don't really know how implement these changes, much less how to implement them so that they fit well into the current code. Thanks in advance for your help and time! |
Okay. I'll work on these changes when I have time. :) |
@dotnet-policy-service agree |
Hello! I made some updates to Oligopoly:
UpdateSharePricesmethod, which changes the prices of all companies in the range from -3 to 3 percent. I thought it would make the gaming market a little more dynamic.