Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Oligopoly update#79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Fuinny wants to merge801 commits intodotnet:mainfromFuinny:main
Closed

Oligopoly update#79

Fuinny wants to merge801 commits intodotnet:mainfromFuinny:main

Conversation

@Fuinny
Copy link
Contributor

Hello! I made some updates to Oligopoly:

  • I changed the design of letters and tables a little.
  • I added a turn counter.
  • I added theUpdateSharePrices method, which changes the prices of all companies in the range from -3 to 3 percent. I thought it would make the gaming market a little more dynamic.
  • I added two new companies and events to them (adding new companies and events would probably be a good first issue btw :D)
  • I added global events, they are generated every 50th turn and affect the prices of all companies.
  • I added the ability to choose difficulty and game mode.

ZacharyPattenand others added30 commitsJuly 2, 2022 21:53
Added 3 monsters: Chopper, Magneto & Musikradio, however musikradio may be used as a sign.Added Sprites: Train Instructor, Cap SpriteAdded Hats: For Customisation hats can belong to the player
Fixed: Positioning of the Sprites
Fixed Sprite Left Idle
@ZacharyPatten
Copy link
Collaborator

Thanks for another pull request.

Feel free to try it if you want to, but I can update the web version of the code for you to match your latest console version.

I'll review this pull request as soon as I can.

@Fuinny
Copy link
ContributorAuthor

Okay, at least I tried :D

@FuinnyFuinnyforce-pushed themain branch 2 times, most recently frome8edd7a to1eea61cCompareJune 4, 2023 18:06
@Fuinny
Copy link
ContributorAuthor

I think I fixed it... feel dumb :D

@ZacharyPatten
Copy link
Collaborator

ZacharyPatten commentedJun 10, 2023
edited
Loading

Okay I had some time to review the pull request and here are some comments I have:

I don't think there should be multiple screens for choosing game-mode/difficulty. Right now the code has both a "GAME MODE" screen and a "DIFFICULTY" screen. Instead just have a single options screen maybe with a check box for having "random starting stock values" as a toggle-able option.

I like the idea of adding different difficulties, but changing theLosingNetWorth andWinningNetWorth isn't actually changing the statistical difficulty of the game. All this does is change how long the game is to play in order to win or lose. Instead, if we want to add different difficulties into the game, we should apply a weight to the random selection of events to so there is a bias towards positive/negative events based on the current difficulty. I don't think we need to change theLosingNetWorth andWinningNetWorth between the difficulties personally, just the event bias. For example, could have...

  • easy difficulty has a60% chance that the next market event will bepositive
  • normal difficulty has a50% chance that the next market event will bepositive/negative
  • hard difficulty has a60% change that the next market event will benegative

@ZacharyPatten
Copy link
Collaborator

@Fuinny

If you would like me to make the changes to difficulty that I am recommending let me know. But since that would be a change to the game's design I wanted to wait and hear your thoughts before I made that change.

@Fuinny
Copy link
ContributorAuthor

@ZacharyPatten

Thanks for reviewing my code!

Yes, I think that changing the chances of events would be more interesting than changing the win/lose conditions. I did not even think about such an implementation of difficulties, thanks for the improved idea!

Also, as a suggestion, we can add another checkbox (along with the random mode) that will allow the player to manually adjust the amount of money at the start. It can be called something likecustom mode or something (and we also need to prevent the player from selecting both modes at the same time). What do you think?

@ZacharyPatten
Copy link
Collaborator

@ZacharyPatten

Thanks for reviewing my code!

Yes, I think that changing the chances of events would be more interesting than changing the win/lose conditions. I did not even think about such an implementation of difficulties, thanks for the improved idea!

Also, as a suggestion, we can add another checkbox (along with the random mode) that will allow the player to manually adjust the amount of money at the start. It can be called something likecustom mode or something (and we also need to prevent the player from selecting both modes at the same time). What do you think?

Yeah having a slider or whatever for initial funds is probably a good idea. :) Would you like me to jump in and implement these changes your would you like to work on them? I just don't want us to step on each other's toes by both working on those changes at the same time.

@Fuinny
Copy link
ContributorAuthor

To be honest, I need help with the implementation of this :D I don't really know how implement these changes, much less how to implement them so that they fit well into the current code. Thanks in advance for your help and time!

@ZacharyPatten
Copy link
Collaborator

Okay. I'll work on these changes when I have time. :)

Fuinny reacted with heart emoji

@ZacharyPattenZacharyPatten marked this pull request as draftJune 22, 2023 14:54
@Fuinny
Copy link
ContributorAuthor

@dotnet-policy-service agree

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ZacharyPattenZacharyPattenAwaiting requested review from ZacharyPattenZacharyPatten is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Fuinny@ZacharyPatten@ZilasJoergensen@Mozin0@Rinzii@CoDA-420@AsrielKujo@UltimateSingularity

[8]ページ先頭

©2009-2025 Movatter.jp