- Notifications
You must be signed in to change notification settings - Fork163
Duck Hunt#39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Duck Hunt#39
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ZacharyPatten commentedJun 12, 2022
Thank you for your interest in contributing a#17 new game. This looks great! :) Do you have an opinion on what you believe the"Weight" should be on the table in the root We need to add some additional files (see the "New Game Contribution Checklist" on#17), but I can do that for you. My main comment from a code review perspective is that I think we can optimize the code a bit. On large screen sizes the game seems to lag a bit. I have a few ideas on how we can easily optimize it. I will keep you updated if I make progress on this topic. |
CorinHyndman commentedJun 12, 2022
The"Weight" I would say is on par with Tanks so maybe a 4? |
ZacharyPatten commentedJun 14, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I see you added some optimizations. Thanks! I will review when I have time. :) Also, ignore the GitHub action breaking on your fork. I need to update my "Website Deploy" action to only run on my repo (and not on forks). Sorry! |
ZacharyPatten commentedJun 15, 2022
I have added the blazor port, and I made a few changes in hopes to prevent the game from crashing when the console window is resized. I'm sure there is more improvement that could be done (especially in the blazor port), but everything seems functioning and pretty reliable. I feel like this pull request is ready to merge. :) Thanks again for the great contribution! Feel free to open up additional pull requests if you would like to update the game in the future. |
No description provided.