Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add missing exception documentation for DateTime.TryParseExact#11513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tarekgh merged 2 commits intodotnet:mainfromcasuffitsharp:10886
Jun 26, 2025

Conversation

casuffitsharp
Copy link
Contributor

Summary

This PR adds missing exception documentation to DateTime.TryParseExact to reflect its actual behavior.

  • Documents the FormatException that is thrown when the format string argument itself is invalid.
  • Adds the ArgumentException documentation to overloads where it was missing to ensure consistency.

The new FormatException text is based on the description from DateTime.ToString(format) for consistency with the existing API documentation.

Fixes#10886

@casuffitsharpcasuffitsharp requested a review froma team as acode ownerJune 25, 2025 20:32
@github-actionsgithub-actionsbot added the needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners labelJun 25, 2025
@dotnet-policy-servicedotnet-policy-servicebot added the community-contributionIndicates that the PR has been added by a community member labelJun 25, 2025
@casuffitsharp
Copy link
ContributorAuthor

@dotnet-policy-service agree

@casuffitsharp
Copy link
ContributorAuthor

@tarekgh tagging you as requested

tarekgh reacted with thumbs up emoji

@casuffitsharpcasuffitsharp marked this pull request as draftJune 25, 2025 20:38
@casuffitsharpcasuffitsharp marked this pull request as ready for reviewJune 25, 2025 20:47
@tarekghtarekgh added area-System.DateTime and removed needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners labelsJun 26, 2025
Copy link
Member

@tarekghtarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

Thanks@casuffitsharp

@tarekgh
Copy link
Member

tarekgh commentedJun 26, 2025•
edited
Loading

@gewarren do you want to have a quick look at this one before I merge it? Also, do you know why the preview page is not generated to look at the visuals of the change?

Copy link
Contributor

@gewarrengewarren left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. You can get to thepreview from here:

image

image

tarekgh reacted with thumbs up emoji
@casuffitsharp
Copy link
ContributorAuthor

@gewarren should the preview be accessible for us too? Just to confirm, because I can't access (requires login)

@tarekghtarekgh merged commita150563 intodotnet:mainJun 26, 2025
5 of 6 checks passed
@casuffitsharpcasuffitsharp deleted the 10886 branchJune 26, 2025 17:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tarekghtarekghtarekgh approved these changes

@gewarrengewarrengewarren approved these changes

Assignees
No one assigned
Labels
area-System.DateTimecommunity-contributionIndicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incomplete documentation on DateTime.TryParseExact
3 participants
@casuffitsharp@tarekgh@gewarren
[8]ページ先頭
©2009-2025 Movatter.jp