Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add missing TimeoutException to WaitAsync(TimeSpan, TimeProvider, CancellationToken) documentation#11481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gewarren merged 2 commits intomainfromcopilot/fix-11190
Jun 30, 2025

Conversation

Copilot
Copy link
Contributor

@CopilotCopilotAI commentedJun 19, 2025
edited
Loading

TheTask.WaitAsync(TimeSpan, TimeProvider, CancellationToken) method documentation had an inconsistency where the parameter description fortimeout mentioned that aTimeoutException would be thrown when the timeout expires, but this exception was not listed in the method's exceptions section.

Before:
The exceptions section only listed:

  • ArgumentNullException
  • OperationCanceledException

After:
Added the missingTimeoutException with the description: "The timeout expired. This exception is stored into the returned task."

This change ensures consistency between the parameter documentation and the exceptions section, making it clear to developers that they need to handleTimeoutException when using this method.

The fix follows the same pattern used for other timeout-related exceptions in the codebase and maintains consistency with similarWaitAsync method overloads.

Fixes#11190.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Clickhere to start the survey.

…cellationToken) documentationCo-authored-by: jeffhandley <1031940+jeffhandley@users.noreply.github.com>
@CopilotCopilotAI changed the title[WIP]Task.WaitAsync(TimeSpan, TimeProvider, CancellationToken) does not listTimeoutException as a possible exceptionAdd missing TimeoutException to WaitAsync(TimeSpan, TimeProvider, CancellationToken) documentationJun 19, 2025
@CopilotCopilotAI requested a review fromjeffhandleyJune 19, 2025 07:07
Copilot finished work on behalf ofjeffhandleyJune 19, 2025 07:07
@jeffhandleyjeffhandley marked this pull request as ready for reviewJune 20, 2025 01:50
@jeffhandleyjeffhandley requested a review froma teamJune 21, 2025 03:18
@gewarrengewarren merged commit8645ca1 intomainJun 30, 2025
12 of 14 checks passed
@gewarrengewarren deleted the copilot/fix-11190 branchJune 30, 2025 13:39
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes

@gewarrengewarrengewarren approved these changes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task.WaitAsync(TimeSpan, TimeProvider, CancellationToken) does not listTimeoutException as a possible exception
3 participants
@Copilot@jeffhandley@gewarren

[8]ページ先頭

©2009-2025 Movatter.jp