- Notifications
You must be signed in to change notification settings - Fork1.6k
Fix INumber.Sign documentation for zero return value#11480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: jeffhandley <1031940+jeffhandley@users.noreply.github.com>
Copilot finished work on behalf ofjeffhandleyJune 19, 2025 07:03
jeffhandley approved these changesJun 20, 2025
Tagging subscribers to this area: @dotnet/area-system-numerics |
gewarren approved these changesJun 30, 2025
e819bd5
intomain 10 of 11 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The documentation for
INumber<T>.Sign
method incorrectly stated that when the input value is zero, it returnsINumberBase<TSelf>.Zero
. However, the actual behavior is that it returns the integer value0
(Int32).Changes Made
xml/System.Numerics/INumber
1.xmlto correctly state that zero inputs return
0instead of referencing
INumberBase.Zero`Before
After
This aligns with the method's actual return type of
System.Int32
and matches the behavior documented in the code examples showing thatMath.Sign()
returns integer values (0, 1, -1).Fixes#11207.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Clickhere to start the survey.