Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix Task.WhenAny documentation typo: change "result value is true" to "This is true"#11477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gewarren merged 4 commits intomainfromcopilot/fix-11350
Jul 1, 2025

Conversation

Copilot
Copy link
Contributor

@CopilotCopilotAI commentedJun 19, 2025
edited
Loading

This PR fixes a documentation typo in theTask.WhenAny method remarks that was causing confusion about the return value.

Problem

The documentation incorrectly stated:

The result value istrue even if the first task to complete ended in the Canceled or Faulted state.

This wording is misleading because the result value is not literallytrue - it's the first task to complete. The sentence was trying to convey that the behavior described (setting Result to the first task) is true regardless of the task's completion state.

Solution

Changed the wording to:

This istrue even if the first task to complete ended in the Canceled or Faulted state.

This clarifies that the statement refers to the behavior being true, not the result value being the booleantrue.

Changes Made

  • Fixed documentation inWhenAny(Task task1, Task task2) method
  • Fixed documentation inWhenAny<TResult>(Task<TResult> task1, Task<TResult> task2) method
  • Both changes are in/xml/System.Threading.Tasks/Task.xml

The fix makes the documentation consistent with otherWhenAny overloads that already use the correct wording.

Fixes#11350.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Clickhere to start the survey.

…o 'This is true'Co-authored-by: jeffhandley <1031940+jeffhandley@users.noreply.github.com>
@CopilotCopilotAI changed the title[WIP] What happens when one of the argument tasks throws an exception is unclearFix Task.WhenAny documentation typo: change "result value is true" to "This is true"Jun 19, 2025
@CopilotCopilotAI requested a review fromjeffhandleyJune 19, 2025 06:54
Copilot finished work on behalf ofjeffhandleyJune 19, 2025 06:54
@dotnet-policy-servicedotnet-policy-servicebot added the needs-author-actionAn issue or pull request that requires more info or actions from the author. labelJun 19, 2025
…ew feedbackCo-authored-by: jeffhandley <1031940+jeffhandley@users.noreply.github.com>
@dotnet-policy-servicedotnet-policy-servicebot removed the needs-author-actionAn issue or pull request that requires more info or actions from the author. labelJun 19, 2025
@CopilotCopilotAI requested a review fromjeffhandleyJune 19, 2025 07:14
Copilot finished work on behalf ofjeffhandleyJune 19, 2025 07:14
@jeffhandleyjeffhandley marked this pull request as ready for reviewJune 20, 2025 01:45
@jeffhandleyjeffhandley requested a review froma teamJune 21, 2025 03:17
@dotnet-policy-serviceDotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-threading-tasks

Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com>
auto-merge was automatically disabledJune 30, 2025 13:46

Head branch was pushed to by a user without write access

Copilot finished work on behalf ofgewarrenJune 30, 2025 13:46
@CopilotCopilotAI requested a review fromgewarrenJune 30, 2025 13:46
@gewarrengewarrenenabled auto-merge (squash)June 30, 2025 14:05
@gewarrengewarren merged commit7f1d3c5 intomainJul 1, 2025
5 checks passed
@gewarrengewarren deleted the copilot/fix-11350 branchJuly 1, 2025 10:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes

@gewarrengewarrenAwaiting requested review from gewarren

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What happens when one of the argument tasks throws an exception is unclear
3 participants
@Copilot@jeffhandley@gewarren

[8]ページ先頭

©2009-2025 Movatter.jp