Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Document Base64Url character encoding details in API reference#11470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jeffhandley merged 3 commits intomainfromcopilot/fix-11469
Jun 20, 2025

Conversation

Copilot
Copy link
Contributor

@CopilotCopilotAI commentedJun 19, 2025
edited
Loading

This PR enhances the documentation for theSystem.Buffers.Text.Base64Url class to clearly specify which characters are used in Base64Url encoding, addressing a documentation gap identified by users.

Changes Made

Class-level documentation:

  • Updated the<remarks> section to explain that Base64Url uses the same alphabet as standard Base64 encoding, except that the characters+ and/ are replaced with- and_ respectively to make the output URL-safe.

Method-level documentation:

  • Enhanced the<remarks> section for all encoding methods (EncodeToString,EncodeToChars,EncodeToUtf8, and their overloads) to mention the specific character replacements.
  • Applied changes consistently across all 10 encoding method overloads to maintain API documentation consistency.

Before

The documentation only mentioned "URL-safe ASCII encoded text" and "Base64Url characters" without specifying what makes it URL-safe or what the actual character set differences are.

After

The documentation now clearly explains:

  • What characters replace the standard Base64+ and/ characters (namely- and_)
  • Why these replacements make the encoding URL-safe
  • This information is consistently documented across all relevant methods

This change helps developers understand the practical differences between standard Base64 and Base64Url encoding without having to reference external specifications.

Fixes#11469.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn moreCopilot coding agent tips in the docs.

Co-authored-by: jeffhandley <1031940+jeffhandley@users.noreply.github.com>
@CopilotCopilotAI changed the title[WIP] Mention the characters used in web-safe base64 encodingDocument Base64Url character encoding details in API referenceJun 19, 2025
@CopilotCopilotAI requested a review fromjeffhandleyJune 19, 2025 05:31
Copilot finished work on behalf ofjeffhandleyJune 19, 2025 05:31
@jeffhandleyjeffhandley marked this pull request as ready for reviewJune 19, 2025 05:36
@jeffhandleyjeffhandley requested a review froma team as acode ownerJune 19, 2025 05:36
@jeffhandleyjeffhandleyenabled auto-merge (squash)June 19, 2025 06:33
Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com>
auto-merge was automatically disabledJune 19, 2025 07:39

Head branch was pushed to by a user without write access

@CopilotCopilotAI requested a review fromgewarrenJune 19, 2025 07:39
Copilot finished work on behalf ofgewarrenJune 19, 2025 07:39
@jeffhandleyjeffhandley merged commit6a1b0a7 intomainJun 20, 2025
5 checks passed
@jeffhandleyjeffhandley deleted the copilot/fix-11469 branchJune 20, 2025 01:51
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes

@gewarrengewarrengewarren approved these changes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mention the characters used in web-safe base64 encoding
3 participants
@Copilot@jeffhandley@gewarren

[8]ページ先頭

©2009-2025 Movatter.jp