Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix description of pointer in ldloca.s#11314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jkotas merged 3 commits intodotnet:mainfromSmaug123:pointer-type
Jul 5, 2025

Conversation

Smaug123
Copy link
Contributor

Summary

ECMA-335 6th edition states:

The ldloca instruction pushes the address of the local variable number indx onto the stack, where local variables are numbered 0 onwards. The value pushed on the stack is already aligned correctly for use with instructions like ldind and stind. The result is a managed pointer (type &).

The docs forldloca already state that the result is a managed pointer; this PR brings the docs forldloca.s into alignment with the spec and the docs forldloca. (I hope that this change is in fact correct!)

@Smaug123Smaug123 requested a review froma team as acode ownerMay 18, 2025 22:24
@dotnet-policy-servicedotnet-policy-servicebot added the community-contributionIndicates that the PR has been added by a community member labelMay 18, 2025
@github-actionsgithub-actionsbot added the needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners labelMay 20, 2025
@gewarrengewarren added area-System.Reflection.Emit and removed needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners labelsMay 20, 2025
Copy link
Member

@jkotasjkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This issue was addressed by#9574, but this place was missed. We should apply the same change here for consistency.

@dotnet-policy-servicedotnet-policy-servicebot added the needs-author-actionAn issue or pull request that requires more info or actions from the author. labelJul 3, 2025
@dotnet-policy-servicedotnet-policy-servicebot removed the needs-author-actionAn issue or pull request that requires more info or actions from the author. labelJul 4, 2025
Copy link
Member

@jkotasjkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@jkotasjkotasenabled auto-merge (squash)July 5, 2025 03:37
@jkotasjkotas merged commit03a95c5 intodotnet:mainJul 5, 2025
5 checks passed
@Smaug123Smaug123 deleted the pointer-type branchJuly 5, 2025 06:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jkotasjkotasjkotas approved these changes

Assignees
No one assigned
Labels
area-System.Reflection.Emitcommunity-contributionIndicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Smaug123@jkotas@gewarren
[8]ページ先頭
©2009-2025 Movatter.jp