Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix wording of ldloca description#11313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jkotas merged 2 commits intodotnet:mainfromSmaug123:fix-emit-opcode
Jul 4, 2025
Merged

Conversation

Smaug123
Copy link
Contributor

@Smaug123Smaug123 commentedMay 18, 2025•
edited
Loading

Summary

The current phrasing in the numbered list unambiguously and incorrectly means "dereference the local variable, which is guaranteed to contain an address, and push that address to the stack". The rest of the text correctly implies instead that it means "push the address of the local variable".

ECMA-335 6th edition states:

The ldloca instruction pushes the address of the local variable number indx onto the stack, where local variables are numbered 0 onwards.

@Smaug123Smaug123 requested a review froma team as acode ownerMay 18, 2025 22:21
@dotnet-policy-servicedotnet-policy-servicebot added the community-contributionIndicates that the PR has been added by a community member labelMay 18, 2025
@github-actionsgithub-actionsbot added the needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners labelMay 20, 2025
@gewarrengewarren added area-System.Reflection.Emit and removed needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners labelsMay 20, 2025
Copy link
Member

@jkotasjkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks

@jkotas
Copy link
Member

Could you please resolve the conflict?

@Smaug123
Copy link
ContributorAuthor

Thanks; done.

@jkotasjkotas merged commit01c0e96 intodotnet:mainJul 4, 2025
5 checks passed
@jkotas
Copy link
Member

Thank you! Could you please fix up#11314 as well?

@Smaug123Smaug123 deleted the fix-emit-opcode branchJuly 4, 2025 17:55
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jkotasjkotasjkotas approved these changes

Assignees
No one assigned
Labels
area-System.Reflection.Emitcommunity-contributionIndicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Smaug123@jkotas@gewarren
[8]ページ先頭
©2009-2025 Movatter.jp