Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Explain semantics of multiple calls toCancellationTokenSource.Cancel#11105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Smaug123 wants to merge3 commits intodotnet:main
base:main
Choose a base branch
Loading
fromSmaug123:cancellation

Conversation

Smaug123
Copy link
Contributor

Also copy a line about LIFO semantics from one of the overloads, to unify the docs for each function.

Summary

Earlier today, I needed to perform several experiments to discover the semantics ofCancellationTokenSource.Cancel, because they are undocumented.

I don't know the semantics ofCancelAsync, so I haven't documented them.

Also copy a line about LIFO semantics from one of the overloads,to unify the docs for each function.
@github-actionsgithub-actionsbot added the needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners labelMar 18, 2025
@dotnet-policy-servicedotnet-policy-servicebot added the community-contributionIndicates that the PR has been added by a community member labelMar 18, 2025
@Smaug123Smaug123 marked this pull request as ready for reviewMarch 18, 2025 20:09
@learn-build-service-prodLearn Build Service (PROD)

Learn Build status updates of commit5a2b566:

✅ Validation status: passed

FileStatusPreview URLDetails
xml/System.Threading/CancellationTokenSource.xml✅SucceededView

For more details, please refer to thebuild report.

For any questions, please:

@gewarrengewarren added area-System.Threading and removed needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners labelsMar 25, 2025
Copy link
Contributor

@gewarrengewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I left some grammatical suggestions. Thanks!

@Smaug123
Copy link
ContributorAuthor

Some scope creep, but I've gone over every use of the word "will" in the file and replaced it with a present tense unless it's describing asynchrony or future actions.

gewarren reacted with thumbs up emoji

@learn-build-service-prodLearn Build Service (PROD)

Learn Build status updates of commit8094c7a:

✅ Validation status: passed

FileStatusPreview URLDetails
xml/System.Threading/CancellationTokenSource.xml✅SucceededView

For more details, please refer to thebuild report.

For any questions, please:

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gewarrengewarrengewarren left review comments

@kouvelkouvelAwaiting requested review from kouvel

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-System.Threadingcommunity-contributionIndicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Smaug123@gewarren
[8]ページ先頭
©2009-2025 Movatter.jp