Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed documentation for MemoryLoadBytes#10303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
mrsharm wants to merge8 commits intodotnet:main
base:main
Choose a base branch
Loading
frommrsharm:memory_fix

Conversation

mrsharm
Copy link
Member

@mrsharmmrsharm commentedAug 23, 2024
edited
Loading

Summary

Fixed documentation for theMemoryLoadBytes section as it was misleading before as it's not a percentage but a quantity with units in bytes.

Fixes an issue in the runtime repo:dotnet/runtime#106712

CC:@Maoni0@cshung@mangod9@markples

@mrsharmmrsharm requested a review froma team as acode ownerAugust 23, 2024 18:37
@dotnet-policy-servicedotnet-policy-servicebot added the community-contributionIndicates that the PR has been added by a community member labelAug 23, 2024
@dotnet-policy-serviceDotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime

@learn-build-service-prodLearn Build Service (PROD)

This comment was marked as outdated.

Copy link
Contributor

@gewarrengewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for updating this. The wording wasn't exactly clear to me, so I left a suggested change.

mrsharm reacted with thumbs up emoji
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Copy link
Contributor

@gewarrengewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oops, forgot to change the link in my previous review. We're required to leave off the learn.microsoft.com/locale part of URLs for them to resolve in air-gapped environments.

@learn-build-service-prodLearn Build Service (PROD)

This comment was marked as outdated.

@Maoni0
Copy link
Member

this still reads a bit confusing to me. for example, not sure how the reader would interpret whatmemory load is a field in the MEMORYSTATUS structure in bytes means and this was the original confusion indicated indotnet/runtime#94565. I'd suggest we enumerate all cases to make it very clear, something like this -

when a process is not running in a container or running in a container without a memory limit -

  • on windows this is (the memory load field of the MEMORYSTATUS structure (which is a percentage) * total physical memory available on the machine).
  • on Linux this is the MemAvailable field in /proc/meminfo.
  • on FreeBSD...
  • ...

when a process is running in a container with a memory limit -

  • on Windows...
  • ...

also CC-ing@janvorli for review on info about non windows side of things.

mrsharm reacted with thumbs up emoji

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@learn-build-service-prodLearn Build Service (PROD)

This comment was marked as outdated.

@learn-build-service-prodLearn Build Service (PROD)

This comment was marked as outdated.

@learn-build-service-prodLearn Build Service (PROD)

This comment was marked as outdated.

@mrsharm
Copy link
MemberAuthor

@janvorli, any feedback here? Explicitly highlighted the source of the memory load calculation, which prior to this change was ambiguously stated. Based on the code ofGCToOSInterface::GetMemoryStatus, there were two cases: one with a memory limit set and one without whether in a container or not -- these were basically added to the documentation.

@learn-build-service-prodLearn Build Service (PROD)

Learn Build status updates of commit832b8f5:

✅ Validation status: passed

FileStatusPreview URLDetails
xml/System/GCMemoryInfo.xml✅SucceededView

For more details, please refer to thebuild report.

For any questions, please:

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gewarrengewarrengewarren approved these changes

@janvorlijanvorliAwaiting requested review from janvorli

Assignees
No one assigned
Labels
area-System.Runtimecommunity-contributionIndicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mrsharm@Maoni0@gewarren

[8]ページ先頭

©2009-2025 Movatter.jp