- Notifications
You must be signed in to change notification settings - Fork92
[Version 9.0] Feature support for extension GetEnumerator in foreach#1472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
RexJaeschke wants to merge1 commit intodraft-v9Choose a base branch
base:draft-v9
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains all the changes in#989. It also replaces PR#1463, which has been retired.
Some background: When Rex created 989, he used draft-v7 as the base. However, during the v8 work the affected subclause, 13.9.5 "The foreach statement," was subsequently split into 3 subclauses, and text was moved around, changed, and augmented due to the addition of the async streams and using declarations features. Then when Bill pushed 989 into 1463, things got confused with unchanged text being reported as new, and Rex's new text going in the wrong place.
Reviewers: The changes made by this PR were donewithout consideration of any impact the v8 features async streams and using declarations might have. As such, see if these changes are impacted by 13.5.3, "await foreach."