- Notifications
You must be signed in to change notification settings - Fork92
Fix tuple assignment#1366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:draft-v8
Are you sure you want to change the base?
Fix tuple assignment#1366
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -345,7 +345,7 @@ In all cases, the rules ensure that a conversion is executed as a boxing convers | ||
| ### 10.2.13 Implicit tuple conversions | ||
| An implicit conversion exists froman expression `E` witha tupletype `S` to a tuple type `T` if `S` has the same arity as `T` and an implicit conversion exists from each element type in `S`to the corresponding element typein `T`. | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I think I'm following, but just checking.Is there a tuple type (object,object)x=(default,default); | ||
| If an element name in the tuple expression does not match a corresponding element name in the tuple type, a warning shall be issued. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -33,12 +33,12 @@ An ***instance accessor*** is a property access on an instance, an event access | ||
| ### 12.2.2 Values of expressions | ||
| Most of the constructs that involve an expression ultimately require the expression to denote a ***value***. In such cases, if the actual expression denotes a namespace, a type, a method group, or nothing, a compile-time error occurs. However, if the expression denotes a property access, an indexer access,a tuple,or a variable, the value of the property, indexer, tuple, or variable is implicitly substituted: | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Why do we mention tuple expressions here, but we don't mention other kinds of expressions such as object creation expressions, array creation expressions, lambda expressions, and so on? | ||
| - The value of a variable is simply the value currently stored in the storage location identified by the variable. A variable shall be considered definitely assigned ([§9.4](variables.md#94-definite-assignment)) before its value can be obtained, or otherwise a compile-time error occurs. | ||
| - The value of a property access expression is obtained by invoking the get accessor of the property. If the property has no get accessor, a compile-time error occurs. Otherwise, a function member invocation ([§12.6.6](expressions.md#1266-function-member-invocation)) is performed, and the result of the invocation becomes the value of the property access expression. | ||
| - The value of an indexer access expression is obtained by invoking the get accessor of the indexer. If the indexer has no get accessor, a compile-time error occurs. Otherwise, a function member invocation ([§12.6.6](expressions.md#1266-function-member-invocation)) is performed with the argument list associated with the indexer access expression, and the result of the invocation becomes the value of the indexer access expression. | ||
| - The value of a tuple expression isthe valueobtained byevaluating thetupleexpression (§12.8.6). It is an error to obtain the value of a tuple expression that does not have a type. | ||
| ## 12.3 Static and Dynamic Binding | ||
| @@ -1611,7 +1611,7 @@ A tuple expression has a type if and only if each of its element expressions `Ei | ||
| A tuple expression is evaluated by evaluating each of its element expressions in order from left to right. | ||
| A tuple valueisobtained from a tuple expression byevaluating itand storing the result in corresponding `System.ValueTuple<...>` type, and initializing each of its fields in order from left to rightbyevaluating the corresponding tuple element expression of `E`, convertingittothecorresponding element typeof`T` using the implicit conversion found, and initializing the field with the result. | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. System.ValueTuple isn't mentioned anywhere else in this file. Shouldn't we be a bit more specific? There are wrinkles in how tuples map to the ValueTuple types. For instance, a tuple type Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I see that conversions.md does mention Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I vaguely remember that we discussed how far we needed to go with that encoding aspect. If we can avoid referring to | ||
| > *Example*: | ||
| > | ||