Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix tuple assignment#1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
BillWagner wants to merge1 commit intodotnet:draft-v8
base:draft-v8
Choose a base branch
Loading
fromBillWagner:errors-in-tuple-assignment

Conversation

@BillWagner
Copy link
Member

Fixes#1155

This PR follows the process outlined in#1155 (comment)

This replaces the first commit in#1159.

See#1359 (review) for the status of this PR.

Fixesdotnet#1155This PR follows the process outlined indotnet#1155 (comment)
@Nigel-Ecma
Copy link
Contributor

Carried over from#1159:

Mypossible fix to#1155 doesn’t deal with the case of atuple_expression not having a type (RIP null type), and one without a type is not representable directly as aValueTuple<…> as there is no type for one or more of the type params…

A re-think is needed, till then I’ll mark this PR as draft

This PR is for that rethink…

@Nigel-EcmaNigel-Ecma added this to theC# 8.0 milestoneJul 3, 2025
@jnm2
Copy link
Contributor

jnm2 commentedJul 3, 2025
edited
Loading

@Nigel-Ecma If a tuple expression doesn't have a type, then I think we don't get to the part whereValueTuple<...> comes into play, because of this text:

The value of a tuple expression is the value obtained by evaluating the tuple expression (§12.8.6). It is an error to obtain the value of a tuple expression that does not have a type.

Thus a tuple expression is only evaluated when it has a type, and thus a tuple expression can be evaluated by constructing the correspondingValueTuple<...> type.

A tuple expression is evaluated by evaluating each of its element expressions in order from left to right.

A tuple valuecan beobtained from a tuple expression byconverting itto a tuple type ([§10.2.13](conversions.md#10213-implicit-tuple-conversions)), by reclassifying it as a value ([§12.2.2](expressions.md#1222-values-of-expressions))) orbymakingit thetargetofa deconstructing assignment ([§12.21.2](expressions.md#12212-simple-assignment)).
A tuple valueisobtained from a tuple expression byevaluating itand storing the result in corresponding`System.ValueTuple<...>` type, and initializing each of its fields in order from left to rightbyevaluating the corresponding tuple element expression of`E`, convertingittothecorresponding element typeof`T` using the implicit conversion found, and initializing the field with the result.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

System.ValueTuple isn't mentioned anywhere else in this file. Shouldn't we be a bit more specific? There are wrinkles in how tuples map to the ValueTuple types. For instance, a tuple type(T1, T2, T3, T4, T5, T6, T7, T8) must be represented as nested ValueTuples, because the TRest type argument of a tuple must always itself be a nested tuple:ValueTuple<T1, T2, T3, T4, T5, T6, T7, ValueTuple<T8>>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I see that conversions.md does mentionValueTuple<...> a few times, but it doesn't explain the required recursive encoding.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I vaguely remember that we discussed how far we needed to go with that encoding aspect.

If we can avoid referring toValueTuple<...> in this section, it's likely to make our lives easier... even if it means doing a bit more work in 8.3.11 to effectively make that theonly place that needs to go into that detail. If we can say "logically there's a type with N fields" then we can make this line (in expressions.md) simpler.

###12.2.2 Values of expressions

Most of the constructs that involve an expression ultimately require the expression to denote a***value***. In such cases, if the actual expression denotes a namespace, a type, a method group, or nothing, a compile-time error occurs. However, if the expression denotes a property access, an indexer access, or a variable, the value of the property, indexer, or variable is implicitly substituted:
Most of the constructs that involve an expression ultimately require the expression to denote a***value***. In such cases, if the actual expression denotes a namespace, a type, a method group, or nothing, a compile-time error occurs. However, if the expression denotes a property access, an indexer access,a tuple,or a variable, the value of the property, indexer, tuple, or variable is implicitly substituted:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why do we mention tuple expressions here, but we don't mention other kinds of expressions such as object creation expressions, array creation expressions, lambda expressions, and so on?

jskeet reacted with thumbs up emoji
### 10.2.13 Implicit tuple conversions
Animplicitconversionexistsfromatupleexpression `E`toatupletype `T`if `E`hasthesamearityas `T`andanimplicitconversionexistsfromeachelementin `E`tothecorrespondingelementtypein `T`.Theconversionisperformedbycreatinganinstanceof `T`’scorresponding `System.ValueTuple<...>`type,andinitializingeachofitsfieldsinorderfromlefttorightbyevaluatingthecorrespondingtupleelementexpressionof `E`,convertingittothecorrespondingelementtypeof `T`usingtheimplicitconversionfound,andinitializingthefieldwiththeresult.
Animplicitconversionexistsfromanexpression `E`withatupletype `S`toatupletype `T`if `S`hasthesamearityas `T`andanimplicitconversionexistsfromeachelementtypein `S`tothecorrespondingelementtypein `T`.
Copy link
Contributor

@jnm2jnm2Jul 3, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think I'm following, but just checking.Is there a tuple typeS for every tuple expression? For instance, does(default, default) have a tuple typeS in:

(object,object)x=(default,default);

jskeet reacted with thumbs up emoji
@jskeet
Copy link
Contributor

@Nigel-Ecma is working on a new PR - he will close this when opening the new one.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jskeetjskeetjskeet left review comments

@jnm2jnm2jnm2 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Nigel-EcmaNigel-Ecma

Labels

None yet

Projects

None yet

Milestone

C# 8.0

Development

Successfully merging this pull request may close these issues.

Tuple conversions are incorrectly specified

4 participants

@BillWagner@Nigel-Ecma@jnm2@jskeet

[8]ページ先頭

©2009-2025 Movatter.jp