Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add the list of attributes that support nullable analysis.#1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@BillWagner
Copy link
Member

Fixes#1092

Based on the last meeting, list the attributes so that their function is normative, however a compiler need not issues warnings based on these rules.

Copy link
Contributor

@Nigel-EcmaNigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

An early review, just comments. In general I’m not sure the must/may language is correct. I haven’t gone through all the examples so no comments there but a glance suggests I'd have similar queries – but examples are informative…

@BillWagnerBillWagner marked this pull request as ready for reviewOctober 24, 2024 20:15
@BillWagnerBillWagner added the meeting: discussThis issue should be discussed at the next TC49-TG2 meeting labelOct 24, 2024
Copy link
Contributor

@Nigel-EcmaNigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just another bunch of comments

Copy link
Contributor

@jskeetjskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One more suggested change, but basically fine. (Thanks!)

Copy link
Contributor

@Nigel-EcmaNigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A couple more comments

BillWagnerand others added14 commitsNovember 11, 2024 12:59
Include all the nullable analysis attributes in the spec. This will be edited heavily and shrunk down to a smaller set of normative text.
Co-authored-by: Nigel-Ecma <perryresearch@zoot.net.nz>Co-authored-by: Jon Skeet <skeet@pobox.com>
Co-authored-by: Jon Skeet <skeet@pobox.com>
Co-authored-by: Nigel-Ecma <perryresearch@zoot.net.nz>
When the `DoesNotReturn` attribute is parsed by a compiler that provides nullable diagnostics, that attribute can't impact reachable code analysis.
@gaftergafter added this to theC# 8.0 milestoneNov 20, 2024
Co-authored-by: Neal Gafter <neal@gafter.com>Co-authored-by: Joseph Musser <me@jnm2.com>
@BillWagnerBillWagner merged commitf4ebeb4 intodotnet:draft-v8Nov 20, 2024
7 checks passed
@BillWagnerBillWagner deleted the nullable-attribute-list branchNovember 20, 2024 20:37
BillWagner added a commit that referenced this pull requestNov 22, 2024
These two attributes were mistakenly added in#1191.  They were removed in#1218This PR adds them back into the `draft-v9` branch, where they are valid.
BillWagner added a commit to BillWagner/csharpstandard that referenced this pull requestDec 10, 2025
These two attributes were mistakenly added indotnet#1191.  They were removed indotnet#1218This PR adds them back into the `draft-v9` branch, where they are valid.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gaftergaftergafter left review comments

@Nigel-EcmaNigel-EcmaNigel-Ecma left review comments

@jnm2jnm2jnm2 left review comments

@jskeetjskeetjskeet approved these changes

Assignees

No one assigned

Labels

meeting: discussThis issue should be discussed at the next TC49-TG2 meeting

Projects

None yet

Milestone

C# 8.0

Development

Successfully merging this pull request may close these issues.

[Nullable Reference Types] Specify behavior for nullable analysis attributes

5 participants

@BillWagner@jskeet@gafter@Nigel-Ecma@jnm2
[8]ページ先頭
©2009-2025 Movatter.jp