This repository was archived by the owner on Jan 23, 2023. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork2.6k
Improve Math.DivRem performance#8125
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Until the JIT is able to eliminate one of the two idiv operations, using a multiplication and subtraction is measurably faster than an extra division.
redknightlois commentedNov 15, 2016
I would aggresively inline it by default if it were my codebase. |
mikedn commentedNov 15, 2016
I'm not sure that using |
MemberAuthor
stephentoub commentedNov 15, 2016
Reverting those |
Went through all uses of % looking for places DivRem could be used. This looks like it's the only one of note.
mikedn commentedNov 15, 2016
LGTM |
1 similar comment
redknightlois commentedNov 15, 2016
LGTM |
jkotas approved these changesNov 15, 2016
MemberAuthor
stephentoub commentedNov 15, 2016
@dotnet-bot test Ubuntu x64 Checked Build and Test please (https://github.com/dotnet/coreclr/issues/6574) |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the discussion athttps://github.com/dotnet/coreclr/issues/3439, this PR at least temporarily changes the implementation of Math.DivRem to avoid two idiv instructions. It then replaces a few % and / pairs in mscorlib with Math.DivRem.
Perf test:
outputs for me:
cc:@jkotas,@mikedn,@redknightlois