NotificationsYou must be signed in to change notification settings
Fork62
Star683

Create a macOS universal binary#313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

baronfel wants to merge4 commits intomain

base:main

Choose a base branch

frommacos-universal-binary

Draft

Create a macOS universal binary#313

baronfel wants to merge4 commits intomainfrommacos-universal-binary

Conversation

Copy link

Member

baronfel commentedOct 24, 2024

Adds a target that

creates arch-specific macos binaries
stitches them together usinglipo to create a universal binary (thanks@rolfbjarne!)

Things we need to think about:

how are these signed/notarized?
how is the universal binary passed to the rest of the build process in the azdo pipelines?
How does the azdo pipeline on mac call the build? Because we'd need it to either call this new target directly or have this target be a dependency of the existing build entry point

cc@joeloff /@marcpopMSFT

rolfbjarne reviewed

Oct 24, 2024

View reviewed changes

src/dotnet-core-uninstall/dotnet-core-uninstall.csproj Outdated

		<_LipoOuputPath>$(PublishDir)\osx-universal\$(AssemblyName)</_LipoOuputPath>
		</PropertyGroup>

		<Exec Command="lipo @(_RidSpecificSingleFile, ' ') -create -output $(_LipoOuputPath)" Condition="$([MSBuild]::IsOSPlatform('OSX'))" />

Copy link

Member

rolfbjarneOct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't know if you care, but this won't work if any of these paths have spaces in them.

src/dotnet-core-uninstall/dotnet-core-uninstall.csproj OutdatedShow resolvedHide resolved

Copy link

MemberAuthor

baronfel commentedOct 29, 2024

Tested this on a m2 machine and it works as expected:

% file dotnet-core-uninstall dotnet-core-uninstall: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64:Mach-O 64-bit executable arm64]dotnet-core-uninstall (for architecture x86_64):Mach-O 64-bit executable x86_64dotnet-core-uninstall (for architecture arm64):Mach-O 64-bit executable arm64