- Notifications
You must be signed in to change notification settings - Fork10.5k
Fix empty render of the ErrorBoundary#64526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
dariatiurina wants to merge2 commits intodotnet:mainChoose a base branch fromdariatiurina:56950-error-boundary
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
+56 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| /// <summary> | ||
| /// Gets or sets a value that indicates whether there is a pending queued render. | ||
| /// </summary> | ||
| internalboolHasPendingQueuedRender |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is there a way how we could implemement this fix forErrorBoundary components without reducing encapsulation for every component? E.g. by overridingStateHasChanged forErrorBoundary.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix empty render of the ErrorBoundary
Description
This PR fixes a bug where ErrorBoundary renders empty content instead of ErrorContent when multiple child components throw errors in quick succession (e.g., errors thrown inside a foreach loop like in the test example).
How it works normally (single error):
The Renderer queues an empty render to clear the subtree, then calls
HandleException, which queues the ErrorContent render. This works correctly.The bug (multiple errors):
When a second error is thrown:
_hasPendingQueuedRender = trueHandleExceptionto queue the ErrorContent renderStateHasChanged()returns early because_hasPendingQueuedRenderis stilltruefrom step 1The queue ends up with:
[empty, ErrorContent, empty]instead of[empty, ErrorContent, empty, ErrorContent]. After the first ErrorContent renders, only the empty render remains in the queue, clearing the error UI.Solution:
After queuing the empty render but before calling
HandleException, manually reset_hasPendingQueuedRendertofalseusing the new internalHasPendingQueuedRenderproperty. This ensuresStateHasChanged()successfully queues the ErrorContent render for each error.Fixes#56950