- Notifications
You must be signed in to change notification settings - Fork10.5k
[release/10.0] Fix minimal API validation for record structs#64517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
github-actions wants to merge2 commits intorelease/10.0Choose a base branch
base:release/10.0
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+370 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…IsComplexTypeCo-authored-by: captainsafia <1857993+captainsafia@users.noreply.github.com>
Contributor
Hi @@github-actions[bot]. Please make sure you've updated the PR description to use theShiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PRclick here. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Backport of#64514 to release/10.0
/cc@captainsafia@copilot
Description
This backport updates the minimal API runtime validation logic to correctly treat user-defined value types—including
record structparameters and nested properties—as complex types. Previously, the validation pipeline only considered classes complex, causing record structs without top-level validation attributes to be skipped entirely.Fixes#64513
Customer Impact
Minimal API users defining request DTOs as
record structwere unable to rely on validation attributes inside those types. This led to missing validation errors and inconsistent behavior between classes and record structs. The fix brings record struct behavior in line with classes and improves model consistency without requiring user code changes.Regression?
Risk
The change expands the definition of “complex type” to include non-primitive value types. This aligns with user expectations and matches typical model binding behavior. Existing special-cased primitive and framework types remain excluded, and new automated tests cover the updated behavior.
Verification
Packaging changes reviewed?