- Notifications
You must be signed in to change notification settings - Fork10.5k
Switch to assetless build for official builds#64515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull request overview
This PR transitions the ASP.NET Core repository to an assetless build configuration to accelerate commit flow to the Virtual Monolithic Repository (VMR). Since ASP.NET Core no longer ships via the official build, this change eliminates unnecessary asset publishing operations and removes build dependencies that previously blocked the publish-build-assets job from executing.
Key Changes
- Simplified publish-build-assets job by removing all
dependsOnconditions, allowing it to run immediately - Added
isAssetlessBuild: trueparameter to indicate no shipping assets are produced - Removed dependencies on Windows, macOS, Linux builds, code signing, tests, and source indexing jobs
Comments suppressed due to low confidence (1)
.azure/pipelines/ci.yml:731
- The post-build template is missing the
isAssetlessBuild: trueparameter. For consistency with the assetless build approach, this parameter should be added to the post-build template parameters to ensure it also skips asset publishing operations (via the-SkipAssetsPublishingflag). AddisAssetlessBuild: trueafter line 731.
- template: /eng/common/templates-official/post-build/post-build.yml@self parameters: publishingInfraVersion: 3 enableSymbolValidation: false enableSigningValidation: false enableNugetValidation: false publishInstallersAndChecksums: true publishAssetsImmediately: true
ViktorHofer left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure this works. Double check post-merge.
wtgodbe commentedNov 24, 2025
Will do - I just copied what SDK did:https://github.com/dotnet/sdk/pull/49113/files |
edda51e intomainUh oh!
There was an error while loading.Please reload this page.
wtgodbe commentedNov 24, 2025
/backport to release/10.0 |
Started backporting to |
Part ofdotnet/dotnet#711,fixes#64510. We don't ship via the official build anymore. Making our build assetless allows aspnetcore commits to flow to the VMR much quicker after merging.