Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[release/10.0] AllowUserStore to update passkey name#64014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wtgodbe merged 4 commits intorelease/10.0frombackport/pr-63981-to-release/10.0
Oct 15, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actionsgithub-actionsbot commentedOct 13, 2025
edited by MackinnonBuck
Loading

Backport of#63981 to release/10.0

/cc@MackinnonBuck

AllowUserStore to update passkey name

Fixes an issue whereUserStore cannot apply updates to a passkey's name after its initial creation.

Description

Microsoft.AspNetCore.Identity.EntityFrameworkCore providesUserStore (users + roles), andUserOnlyStore (users only). Both stores enable associating one or more passkeys with a user. Passkeys are a new feature in .NET 10.

TheUserPasskeyInfo type contains information about a passkey, including its ID, the public key, and the display name (Name).

Some properties inUserPasskeyInfo are mutable, and others are immutable. CallingUserManager.AddOrUpdatePasskeyAsync(user, passkey) will either add a passkey to the user or update only the mutable properties of an existing passkey. These mutable properties consist solely of:

  • Name
  • SignCount
  • IsUserVerified
  • IsBackedUp

The underlying store implementation controls how these properties get updated.UserOnlyStore correctly handled mutations to each of these properties, butUserStore did not update theName property.

This PR fixesUserStore so that theName property gets correctly updated.

Fixes#63923

Customer Impact

Apps that utilizeMicrosoft.AspNetCore.Identity.EntityFrameworkCore and support roles will not be able to change the name of a passkey after its initial creation. A workaround exists, which is to create a custom store type that extendsUserStore and override theAddOrUpdatePasskeyAsync method to exhibit the correct behavior.

Regression?

  • Yes
  • No

Passkeys are a new feature in .NET 10. The feature never previously worked in this code path.

Risk

  • High
  • Medium
  • Low

The fix is simple: copy an additional property that wasn't getting copied. This is not a breaking change and does not require schema changes or database migrations.

Verification

  • Manual (required)
  • Automated

New automated tests have been added to ensure that all store implementations support modifications to all mutable passkey properties.

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@MackinnonBuckMackinnonBuck changed the title[release/10.0] FixUserStore passkey name update[release/10.0] AllowUserStore to update passkey nameOct 13, 2025
@MackinnonBuckMackinnonBuck added the Servicing-approvedShiproom has approved the issue labelOct 13, 2025
@wtgodbe
Copy link
Member

@MackinnonBuck there are some test failures here that look potentially real

@MackinnonBuck
Copy link
Member

@wtgodbe These tests are flaky. For some reason, the database is getting initialized with the wrong schema occasionally. I'm investigating this in#64019

wtgodbe reacted with thumbs up emoji

@wtgodbewtgodbe merged commitebb0398 intorelease/10.0Oct 15, 2025
28 checks passed
@wtgodbewtgodbe deleted the backport/pr-63981-to-release/10.0 branchOctober 15, 2025 17:58
@dotnet-policy-servicedotnet-policy-servicebot added this to the10.0.0 milestoneOct 15, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@BrennanConroyBrennanConroyBrennanConroy approved these changes

@joperezrjoperezrjoperezr approved these changes

Assignees

No one assigned

Labels

Servicing-approvedShiproom has approved the issue

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@wtgodbe@MackinnonBuck@BrennanConroy@joperezr

[8]ページ先頭

©2009-2025 Movatter.jp