Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

UnquarantineRadioButtonGetsResetAfterSubmittingEnhancedForm#63556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@ilonatommy
Copy link
Member

Investigating failures from#63534, I found out that these issues that fail on net8 have 100% pass rate on net9. They can be enabled.

Issues that they refer to are resolved for main. On main we addedWaitAssert in the place that was reported originally as failing. We can backport that change as well.

@ilonatommyilonatommy self-assigned thisSep 5, 2025
CopilotAI review requested due to automatic review settingsSeptember 5, 2025 10:18
@ilonatommyilonatommy requested a review froma team as acode ownerSeptember 5, 2025 10:18
@ilonatommyilonatommy added this to the10.0-rc1 milestoneSep 5, 2025
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR unquarantines two E2E tests that were previously failing on net8 but now have a 100% pass rate on net9. The changes remove the[QuarantinedTest] attributes and replace synchronous assertions withWaitAssert calls for better reliability in the form handling test.

  • Removes quarantine status from two E2E tests that are now stable
  • Updates form handling test to useWaitAssert instead of synchronous assertions for better reliability

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

FileDescription
FormWithParentBindingContextTest.csRemoves quarantine attribute and replacesAssert calls withWaitAssert for radio button form test
EnhancedNavigationTest.csRemoves quarantine attribute from navigation manager URI update test

@ilonatommyilonatommy removed this from the10.0-rc1 milestoneSep 5, 2025
@dotnet-policy-servicedotnet-policy-servicebot added this to the9.0.x milestoneSep 5, 2025
@ilonatommyilonatommy added area-blazorIncludes: Blazor, Razor Components tell-modeIndicates a PR which is being merged during tell-mode labelsSep 5, 2025
@ilonatommy
Copy link
MemberAuthor

NavigationManagerUriGetsUpdatedOnEnhancedNavigation_BothServerAndWebAssembly did fail. There might be a problem with displaying it on the dashboard, I still don't see that failure on net9.

@ilonatommyilonatommy changed the titleUnquarantineNavigationManagerUriGetsUpdatedOnEnhancedNavigation_BothServerAndWebAssembly andRadioButtonGetsResetAfterSubmittingEnhancedFormUnquarantineRadioButtonGetsResetAfterSubmittingEnhancedFormSep 5, 2025
@wtgodbewtgodbe merged commit81b394c intodotnet:release/9.0Sep 5, 2025
25 checks passed
@dotnet-policy-servicedotnet-policy-servicebot modified the milestones:9.0.x,9.0.10Sep 5, 2025
This was referencedOct 14, 2025
This was referencedNov 25, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@javiercnjaviercnjaviercn approved these changes

Assignees

@ilonatommyilonatommy

Labels

area-blazorIncludes: Blazor, Razor Componentstell-modeIndicates a PR which is being merged during tell-mode

Projects

None yet

Milestone

9.0.10

Development

Successfully merging this pull request may close these issues.

3 participants

@ilonatommy@javiercn@wtgodbe
[8]ページ先頭
©2009-2025 Movatter.jp