- Notifications
You must be signed in to change notification settings - Fork10.5k
[release/8.0] Dispose the certificate chain elements with the chain#62994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
* Dispose the certificate chain elements with the chain* Fix the missing brace* Remove snarky comment.* Add another choice using based on review feedback* Styling fixes---------Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR addresses a resource management issue by ensuring that X509Certificate2 objects in certificate chains are properly disposed. The fix prevents potential memory leaks by manually disposing all certificate chain elements before disposing the chain itself.
Key changes:
- Replace
usingdeclarations with try-finally blocks for X509Chain disposal - Add manual disposal of certificate chain elements before disposing the chain
- Fix a syntax error (semicolon to closing brace)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Shared/CertificateGeneration/UnixCertificateManager.cs | Adds proper disposal pattern for X509Chain and its elements, fixes syntax error |
| src/Security/Authentication/Certificate/src/CertificateAuthenticationHandler.cs | Implements the same disposal pattern for certificate validation |
Comments suppressed due to low confidence (1)
src/Shared/CertificateGeneration/UnixCertificateManager.cs:178
- This appears to be fixing a syntax error where a semicolon was incorrectly used instead of a closing brace.
}a6efb8b intorelease/8.0Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Backport of#62531 to release/8.0
Dispose the certificate chain elements with the chain
Fixes an issue in certificate authentication where certificates within a certificate chain were not getting directly disposed.
Description
Failing to dispose each certificate within an X509 chain can create significant GC pressure for applications that frequently perform TLS handshakes. While the previous disposal logic only disposed the
X509Chainitself, this PR updates the logic to first enumerate and dispose each certificate in the chain directly.Customer Impact
The original contribution was from a customer who determined that this issue has a severe negative performance impact on their large scale web application. See#62531 (comment).
Regression?
Risk
The change is straightforward and follows an established disposal pattern.
Verification
Packaging changes reviewed?