- Notifications
You must be signed in to change notification settings - Fork10.4k
Implement POSIX signal handling for DevServer to fix port release issues#62780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge2 commits intomainChoose a base branch fromcopilot/fix-62528
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+58 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Greetings human! You've submitted a PR that modifies code that is shared withhttps://github.com/dotnet/runtime . Please make sure you synchronize this code with the changes in that repo! |
Co-authored-by: maraf <10020471+maraf@users.noreply.github.com>
Copilot finished work on behalf ofmarafJuly 17, 2025 16:45
This was referencedJul 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR implements POSIX signal handling in the WebAssembly DevServer to resolve port release issues when dotnet-watch terminates the process on Unix systems.
Problem
Recent changes in the .NET runtime caused failures in dotnet-watch on Unix-based systems. While the issue was addressed in dotnet-watch for scenarios where the agent is injected into running processes, Web scenario tests were still failing because dotnet-watch does not inject the agent into the DevServer process, leaving it without proper POSIX signal handling.
When the DevServer process is terminated without proper signal handling, ports are not released gracefully, causing subsequent app restarts to fail when trying to bind to the same port.
Solution
This PR adds a
DevServerLifetime
class that mirrors the existingWebHostLifetime
functionality to handle POSIX signals properly:The implementation:
IHostApplicationLifetime.StopApplication()
context.Cancel = true
IDisposable
Changes Made
src/Components/WebAssembly/DevServer/src/Program.cs
to add signal handlingDevServerLifetime
class that implements the same pattern asWebHostLifetime
OperatingSystem.IsLinux()
/OperatingSystem.IsMacOS()
Testing
This is a surgical fix that addresses the core issue without modifying the existing hosting infrastructure.
Fixes#62528.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Clickhere to start the survey.