- Notifications
You must be signed in to change notification settings - Fork10.5k
fetch TLS client hello message from HTTP.SYS#61494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
| internalvoidInvokeTlsClientHelloCallback(ulongconnectionId,IFeatureCollectionfeatures, | ||
| Func<IFeatureCollection,TlsClientHelloCallback,bool>invokeTlsClientHelloCallback) | ||
| { | ||
| if(!_connectionTimestamps.TryAdd(connectionId,_timeProvider.GetUtcNow())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could this be AddOrUpdate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No, because it doesn't tell you if you are the thread that created the entry or not in order for us to decide whether to call the callback or not.
Co-authored-by: Aditya Mandaleeka <adityamandaleeka@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
Backport of#60806
fetch TLS client hello message from HTTP.SYS
Description
Exposes a callback that we'll call with the
byte[]representation of the TLS Client Hello when a connection connects to the server.Fixes#60805
Customer Impact
Allows customers to inspect the TLS Client Hello message for a connection.
Regression?
Risk
Fully opt-in feature so won't affect existing code. Also, if it is turned on, there are a few app context knobs to tweak behavior in case something goes wrong.
Verification
Packaging changes reviewed?