- Notifications
You must be signed in to change notification settings - Fork10.5k
[release/9.0] Readd DiagnosticSource to KestrelServerImpl#60202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
wtgodbe commentedFeb 5, 2025
/azp run |
| Azure Pipelines successfully started running 3 pipeline(s). |
Open
3 tasks
Member
wtgodbe commentedFeb 6, 2025
Just merged 2 more fixes that should unblock CI |
Member
wtgodbe commentedFeb 6, 2025
/azp run |
| Azure Pipelines successfully started running 3 pipeline(s). |
Member
wtgodbe commentedFeb 6, 2025
Java test failure unrelated |
f67beca intorelease/9.0 21 of 25 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This was referencedMar 12, 2025
This was referencedJul 21, 2025
This was referencedNov 17, 2025
Merged
Open
This was referencedNov 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
area-networkingIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Servicing-approvedShiproom has approved the issue
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Backport of#60129 to release/9.0
/cc@BrennanConroy
Readd DiagnosticSource to KestrelServerImpl
Description
During 8.0 we did a bunch of metrics work and accidentally removed
DiagnosticSourcesupport in Kestrel. Wedocument how to monitor your app for bad requests and it doesn't work anymore.Fixes#58911
Customer Impact
Our docs on how to monitor your app for bad requests doesn't work anymore. Customers would instead need to rely on/add logging capturing for this scenario if they even notice that the feature is broken.
1st party as well as a couple customers have hit this.
Regression?
Regressed in .NET 8
Risk
Simple fix, added smoke test to verify, and did a manual test to check it works now.
Verification
Packaging changes reviewed?