Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[release/9.0] Redis distributed cache: add HybridCache usage signal#59886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wtgodbe merged 1 commit intorelease/9.0frombackport/pr-59543-to-release/9.0
Feb 6, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actionsgithub-actionsbot commentedJan 15, 2025
edited by mgravell
Loading

Backport of#59543 to release/9.0

/cc@mgravell

Redis distributed cache: add HybridCache usage signal

Add connection usage marker forHybridCache to improve connection metadata / visibility.

Description

{Detail}

We already use "DC" and "OC" markers on RESP connections to provide a non-intrusive signal that Distributed Cache and Output Cache are being used; since HybridCache is a feature on top of IDistributedCache, here we add an additional "HC" token to indicate that a RESP connection is being used for HybridCache.

We do this by using IServiceProvider (changing the internal RedisCacheImpl(...) constructors) to detect HybridCache as a service. We don't need it to be the official HybridCache specifically (as in .AddHybridCache()) - just that a HybridCache exists. There are no public API or dependency changes required.

Customer Impact

Improves connection metadata / visibility, i.e. we know what different Redis connections are being used for.

No API changes. Improves internal metrics.

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

When servicing release/2.1

  • Make necessary changes in eng/PatchConfig.props

@ghostghost added the area-networkingIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions labelJan 15, 2025
@dotnet-policy-servicedotnet-policy-servicebot added this to the9.0.x milestoneJan 15, 2025
@jodydonetti
Copy link
Contributor

Hi, how does this signal tweak the connection?
Is there something else 3rd party HybridCache implementers should be aware of?

For example with FusionCache it's totally possible to use RedisCache in our apps without being forced to use that as the L2 of FusionCache, even when using it via the HybridCache adapter: in this case the checks I see here would not be technically "correct".

Can a false detection create problems?

Thanks.

@dotnet-policy-servicedotnet-policy-servicebot added the pending-ci-rerunWhen assigned to a PR indicates that the CI checks should be rerun labelJan 24, 2025
@mgravell
Copy link
Contributor

mgravell commentedJan 24, 2025
edited
Loading

Tactics requested; approved 2025-01-24

@mgravellmgravell added the Servicing-approvedShiproom has approved the issue labelJan 27, 2025
@mgravell
Copy link
Contributor

Test failures seem to be build/SDK related:

Xunit.Sdk.EqualException: Assert.Equal() Failure
↓ (pos 4)
Expected: 9.0.0
Actual: 9.0.1

@mgravellmgravell added ask-modeThis issue / PR is a patch candidate which we will bar-check internally before patching it. feature-cachingIncludes: StackExchangeRedis and SqlServer distributed caches labelsJan 27, 2025
@mgravell
Copy link
Contributor

/azp run

@dotnet-policy-servicedotnet-policy-servicebot removed the pending-ci-rerunWhen assigned to a PR indicates that the CI checks should be rerun labelJan 30, 2025
@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mgravell
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@wtgodbe
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mgravell
Copy link
Contributor

(crosses fingers)

@wtgodbe
Copy link
Member

wtgodbe commentedFeb 5, 2025
edited
Loading

(crosses fingers)

Some of the Helix failures in 9.0 should be fixed by a PR I just merged - not sure about the(Build Test: Ubuntu x64) failure here though

@mgravell
Copy link
Contributor

target value 8 is obsolete and will be removed in a future release

Go home, CI server; you're drunk

@wtgodbe
Copy link
Member

Ugh, the machine rollout happened last night, which means we need to take a JDK update.#60229 should unblock

@wtgodbe
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@wtgodbe
Copy link
Member

Java test failures unrelated

mgravell reacted with heart emoji

This was referencedNov 17, 2025
This was referencedNov 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@captainsafiacaptainsafiacaptainsafia approved these changes

@halter73halter73Awaiting requested review from halter73halter73 is a code owner

+1 more reviewer

@mgravellmgravellmgravell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-networkingIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractionsask-modeThis issue / PR is a patch candidate which we will bar-check internally before patching it.feature-cachingIncludes: StackExchangeRedis and SqlServer distributed cachesServicing-approvedShiproom has approved the issue

Projects

None yet

Milestone

9.0.3

Development

Successfully merging this pull request may close these issues.

5 participants

@jodydonetti@mgravell@wtgodbe@captainsafia

[8]ページ先頭

©2009-2025 Movatter.jp