I filedmicrosoft/OpenAPI.NET#1983 to eventually make this a lot smoother.

We do this to ensure that the schemas are always ordered lexicographically by reference ID in the document. This was previously done in theOpenApiSchemaReferenceTransformer but since that's been removed in favor of usingOpenApiSchemaReference directly, we need to do the sorting somewhere.

This is one of the tests we have to temporarily skip while we sort out how schema deduping looks in the new model.

Microsoft.OpenApi marks the parameter list property as nullable in the new model so we use a null suppression here and elsewhere to quiet nullability warnings.

I usedAssert.NotNull in other places so it's not the most consistent but 🤷🏽 .

@darrelmiller Based on our discussions of Nullable vs Optional, I would not expectParameters to be Nullable, sincenull is not an allowed value for theParameters field of anOperation object. But perhaps I am still confused about this.

@mikekistler For my edification, are you expected to produce an empty list in the case where an operation has no parameters? Is it possible to omit theparameters field altogether?

Is it right that this is changing fromstring toString (and for all these from lower to sentence case)? If it is, maybe usingnameof() would be better to avoid theToString() call at runtime (unless the compiler is smart enough to do that automatically?) when it's a constant value.

Is it right that this is changing from string to String (and for all these from lower to sentence case)?

Depends on the definition of write. I primarily did this to make the values more resilient to being read byEnum.Parse<JsonSchemaType> without having case-insensitivity configured.

Wedo setignoreCase: true everywhere we parse these values and users should never interact with the opaque version of the schema but this feels...safer? 😓

Is it right that this is changing from string to String (and for all these from lower to sentence case)? If it is, maybe using nameof() would be better to avoid the ToString() call at runtime (unless the compiler is smart enough to do that automatically?) when it's a constant value.

The compiler doesn't mapToString tonameof.nameof would work for simple types but things might get funky when we support nullability via thetype argument (JsonSchemaType.String | JsonSchemaType.Null) soToString felt like the best approach to rely on consistently.

Is there any risk here ofBaseUri ending with a/ and messing up the concatenation?

The BaseUri is currently implicitly configured by OpenAPI.NET (ref). The default value ends with a GUID and no trailing slash. They don't expose asetter for the property and I believe it's primarily there to have a base document URL for resolving schemas so I don't tink the risk is likely.

Why ignoreCase here and elsewhere when parsing type? Where does this value of type come from that it might not not be the correct case (and that would be okay)?

When System.Text.Json gives us the schema type, it is serialized as a string in all lowercase (object,null,array, etc.) TheJsonSchemaType enum provided by the OpenAPI uses title casing.Enum.Parse is case-sensitive by default soobject won't map toObject unless we use this flag.

The JsonSchemaType enum provided by the OpenAPI uses title casing.

Isn't that a bug?

No, as most enums use title-case (or I guess Pascal scale) for the type names. STJ maps them to an all lower-case identifierhere) which is why we get the inconsistency in casing between whatEnum.ToString() while generate and what the schema will produce.

This does not look right. The top-levelTags field should be an array ofTagObjects, notstrings.

Yep, this is a known bug that I filed on the library over atmicrosoft/OpenAPI.NET#1991. It was fixed but the version with the fix contains a different bugmicrosoft/OpenAPI.NET#2055 so I am sticking with the devil I know for now. 😅

This change looks odd. I suppose the URL is made up so there is no right or wrong -- but usually URLs follow conventions, like "all lowercase" (as the previous URL did) or "camel cased segments". Here there is a mix of lowercase and Pascal case, which is ... odd.

Yep, this is result of the same reason in#59480 (comment). Because we useJsonSchemaType.String.ToString() the default casing produced is titlecase. We can fix this by just using the literal "string" directly.