Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Provide analyzer for removing unneeded public partial class Program#58482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
captainsafia merged 5 commits intomainfrompublic-api-analyzer
Oct 31, 2024

Conversation

captainsafia
Copy link
Member

@captainsafiacaptainsafia commentedOct 17, 2024•
edited
Loading

Follow-up to#58199.

Based on the code generation that we introduced earlier, users can get rid of the explicitpublic partial class Program { } declarations in their source code and rely on the new default behavior.

This PR introduces an analyzer to find these explicit declarations and a code fixer to remove them.

Implements#58488

martincostello and etkr reacted with heart emoji
@ghostghost added the area-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared framework labelOct 17, 2024
@captainsafiacaptainsafia added analyzerIndicates an issue which is related to analyzer experience feature-mvc-testingMVC testing package area-minimalIncludes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared framework labelsOct 17, 2024
Copy link
Member

@martincostellomartincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

:shipit:

@captainsafiacaptainsafia marked this pull request as ready for reviewOctober 17, 2024 19:26
@dotnet-policy-servicedotnet-policy-servicebot added the pending-ci-rerunWhen assigned to a PR indicates that the CI checks should be rerun labelOct 25, 2024
@captainsafiacaptainsafia removed the pending-ci-rerunWhen assigned to a PR indicates that the CI checks should be rerun labelOct 28, 2024
@captainsafiacaptainsafiaenabled auto-merge (squash)October 30, 2024 22:18
@captainsafiacaptainsafia merged commit95a8ea7 intomainOct 31, 2024
27 checks passed
@captainsafiacaptainsafia deleted the public-api-analyzer branchOctober 31, 2024 18:06
@dotnet-policy-servicedotnet-policy-servicebot added this to the10.0-preview1 milestoneOct 31, 2024
captainsafia added a commit that referenced this pull requestFeb 11, 2025
…58482)* Provide analyzer for removing unneeded public partial class Program* Update tests and fix async call* Address feedback* Add test for public partial class with members* Reorganize checks and add tests
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gfoidlgfoidlgfoidl left review comments

@amcaseyamcaseyamcasey left review comments

@mgravellmgravellmgravell approved these changes

@martincostellomartincostellomartincostello approved these changes

@BrennanConroyBrennanConroyBrennanConroy approved these changes

@david-ackerdavid-ackerdavid-acker approved these changes

@halter73halter73Awaiting requested review from halter73

Assignees
No one assigned
Labels
analyzerIndicates an issue which is related to analyzer experiencearea-minimalIncludes minimal APIs, endpoint filters, parameter binding, request delegate generator etcfeature-mvc-testingMVC testing package
Projects
None yet
Milestone
10.0-preview1
Development

Successfully merging this pull request may close these issues.

7 participants
@captainsafia@mgravell@martincostello@gfoidl@BrennanConroy@amcasey@david-acker
[8]ページ先頭
©2009-2025 Movatter.jp